Marshal() and env

[cgt]

Why doesn't the Marshal func use environment variables?

[biztos]

It also doesn't use flags, apparently. This seems like a bug.

Is there any reason for Marshal to ignore the env/flag overrides that affect GetString and friends?

[kzvezdarov]

Disclaimer: I spent ~10 minutes reading the code, might be wrong.

Seems like the Marshal function is missing the stages that marshal the env. variables and the flags. Furthermore, the order of precedence seems to be wrong: the function sets it as defaults<config<overrides<k/v store, while the documentation states that it should be defaults<k/v store<config<env<flags<overrides.

It looks like it would be enough just to add those stages and reorder the marshaling. env would need to use WeakMarshal since the values are stored as strings, while pflags will have to have their values extracted to a map[string]interface{}. I can probably get it done in an hour or so, given that there are no special considerations for these config stores (env and pflags)?

[kzvezdarov]

#44 fixes this, closing as fixed.