Replies: 1 comment
-
Looks like a great idea! Already saw some PR's coming in, thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I cross-referenced the validation attributes with the Laravel 9.x available validation rules and found that there are 18 validation rules that are not implemented as validation attributes yet.
I couldn't find information about which Laravel version this package needs to support, so depending on the version support, I would like to add the following:
I would like to open PR's to add these validation rules.
Also I found that exclude is implemented but not referenced in the docs, the sibling attributes are referenced. The implementation of the exclude however needs an instance of the
ExcludeIf
class to be passed as a parameter. It would make more sense to implement it like the RequiredIf is implementedExcludeIf
Lastly, the
alpha
,alpha_dash
, andalpha_numeric
received an update in 9.49.0 to add theascii
parameter. These could also be updated.Alpha
,AlphaDash
,AlphaNumeric
There are probably more to update, but these are the ones I found.
Beta Was this translation helpful? Give feedback.
All reactions