Skip to content

Commit 529f139

Browse files
committed
style(rubocop): Style/RedundantInitialize is smarter now
1 parent 4e2c4b2 commit 529f139

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/nokogiri/xml/node.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ class Node
123123
# [Yields] Nokogiri::XML::Node
124124
# [Returns] Nokogiri::XML::Node
125125
#
126-
def initialize(name, document) # rubocop:disable Style/RedundantInitialize
127-
# This is intentionally empty.
126+
def initialize(name, document)
127+
# This is intentionally empty, and sets the method signature for subclasses.
128128
end
129129

130130
###

nokogiri.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ Gem::Specification.new do |spec|
330330
spec.add_development_dependency("rake-compiler-dock", "~> 1.2")
331331
spec.add_development_dependency("rdoc", "~> 6.3")
332332
spec.add_development_dependency("rexical", "~> 1.0.7")
333-
spec.add_development_dependency("rubocop", "~> 1.23")
333+
spec.add_development_dependency("rubocop", "~> 1.28", ">= 1.28.2")
334334
spec.add_development_dependency("rubocop-minitest", "~> 0.17")
335335
spec.add_development_dependency("rubocop-performance", "~> 1.12")
336336
spec.add_development_dependency("rubocop-rake", "~> 0.6")

0 commit comments

Comments
 (0)