From b5f985dda23cc88e00dc71f725d55606b6380dc5 Mon Sep 17 00:00:00 2001 From: Ned Molter Date: Mon, 27 Jan 2025 10:40:45 -0500 Subject: [PATCH] some fixes from @braingram review --- tests/test_step.py | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/tests/test_step.py b/tests/test_step.py index c31d236f..24a90419 100644 --- a/tests/test_step.py +++ b/tests/test_step.py @@ -455,7 +455,8 @@ def save(self, path, dir_path=None, *args, **kwargs): return None -def test_save(tmp_cwd): +def test_save_results(tmp_cwd): + """Ensure model saved using custom save method override when save_results=True.""" model = SimpleDataModel() model.saveid = "test" @@ -525,16 +526,6 @@ def save(self, path, dir_path=None, *args, **kwargs): model.save(path, dir_path, *args, **kwargs) -@pytest.mark.xfail(reason="Looping over models only works for list and tuple. This should be fixed.") -def test_save_container(tmp_cwd, model_list): - """ensure list-like save still works for non-list sequence""" - container = SimpleContainer(model_list) - step = StepWithModel() - step.run(container) - for i in range(3): - assert (tmp_cwd / f"test{i}-saved.txt").exists() - - def test_skip_container(tmp_cwd, model_list): step = StepWithModel() step.skip = True