From fee3779c8e3714106b9dce6797850248b534f1c2 Mon Sep 17 00:00:00 2001 From: jemorrison Date: Mon, 9 Sep 2024 18:39:44 -0700 Subject: [PATCH 1/3] remove setting pixel_replace.save to True --- jwst/pipeline/calwebb_spec3.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/jwst/pipeline/calwebb_spec3.py b/jwst/pipeline/calwebb_spec3.py index 7fd69e4373..da31f36823 100644 --- a/jwst/pipeline/calwebb_spec3.py +++ b/jwst/pipeline/calwebb_spec3.py @@ -100,14 +100,12 @@ def process(self, input): self.spectral_leak.save_results = self.save_results self.pixel_replace.suffix = 'pixel_replace' self.pixel_replace.output_use_model = True - self.pixel_replace.save_results = self.save_results # Overriding the Step.save_model method for the following steps. # These steps save intermediate files, resulting in meta.filename # being modified. This can affect the filenames of subsequent # steps. self.outlier_detection.save_model = invariant_filename(self.outlier_detection.save_model) - self.pixel_replace.save_model = invariant_filename(self.pixel_replace.save_model) # Retrieve the inputs: # could either be done via LoadAsAssociation and then manually From 4eff12d94213ca52c0deb7269740a24d33fa7c07 Mon Sep 17 00:00:00 2001 From: jemorrison Date: Mon, 9 Sep 2024 18:48:17 -0700 Subject: [PATCH 2/3] Update change log --- CHANGES.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGES.rst b/CHANGES.rst index cf15011996..df7337fdf4 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -181,6 +181,8 @@ ramp_fitting - Moved the read noise variance recalculation for CHARGELOSS flagging to the C implementation, when the algorithm is ``OLS_C``. [#8697, spacetelescope/stcal#278] +- Updated `calwebb_spec3` to not save the `pixel_replacement` output by default.[#8765] + resample -------- From 9aef4128dd7e3fd3dfc6aec75e8660e1e10060ba Mon Sep 17 00:00:00 2001 From: jemorrison Date: Tue, 10 Sep 2024 10:38:47 -0700 Subject: [PATCH 3/3] add back invariant_filename --- jwst/pipeline/calwebb_spec3.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jwst/pipeline/calwebb_spec3.py b/jwst/pipeline/calwebb_spec3.py index da31f36823..2644bee233 100644 --- a/jwst/pipeline/calwebb_spec3.py +++ b/jwst/pipeline/calwebb_spec3.py @@ -106,6 +106,7 @@ def process(self, input): # being modified. This can affect the filenames of subsequent # steps. self.outlier_detection.save_model = invariant_filename(self.outlier_detection.save_model) + self.pixel_replace.save_model = invariant_filename(self.pixel_replace.save_model) # Retrieve the inputs: # could either be done via LoadAsAssociation and then manually @@ -235,7 +236,6 @@ def process(self, input): # interpolate pixels that have a NaN value or are flagged # as DO_NOT_USE or NON_SCIENCE. result = self.pixel_replace(result) - # Resample time. Dependent on whether the data is IFU or not. resample_complete = None if exptype in IFU_EXPTYPES: