You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when computing the center of an array of RA/Dec points, we use wrap_ra in both cube_build and resample_spec. This deals well with the RA=0 crossing so that one can use a simple mean to find the midpoint between RA=359.9 and RA=0.1. But it does not handle a similar discontinuity at zenith, i.e. were both RA and Dec can be discontinuous.
Instead of reinventing the wheel, we should just use existing functionality in astropy SkyCoord objects to find midpoints and averages between arrays of points.
The text was updated successfully, but these errors were encountered:
Nadia Dencheva to be clear I am creating a new branch today that will pull wrap_ra into assign WCS and then resample and cube build will import it from there. Later on if we can figure out how to use skycoord instead we just have one place to change it - in assign_wcs.
Should I assign this ticket to team_coffee and put it my my sprint ?
Issue JP-2028 was created on JIRA by James Davies [X]:
Currently when computing the center of an array of RA/Dec points, we use
wrap_ra
in bothcube_build
andresample_spec
. This deals well with the RA=0 crossing so that one can use a simple mean to find the midpoint between RA=359.9 and RA=0.1. But it does not handle a similar discontinuity at zenith, i.e. were both RA and Dec can be discontinuous.Instead of reinventing the wheel, we should just use existing functionality in astropy
SkyCoord
objects to find midpoints and averages between arrays of points.The text was updated successfully, but these errors were encountered: