Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SkyCoord instead of wrap_ra in cube_build and resample_spec #5932

Open
stscijgbot-jp opened this issue Apr 6, 2021 · 3 comments
Open

Comments

@stscijgbot-jp
Copy link
Collaborator

stscijgbot-jp commented Apr 6, 2021

Issue JP-2028 was created on JIRA by James Davies [X]:

Currently when computing the center of an array of RA/Dec points, we use wrap_ra in both cube_build and resample_spec. This deals well with the RA=0 crossing so that one can use a simple mean to find the midpoint between RA=359.9 and RA=0.1. But it does not handle a similar discontinuity at zenith, i.e. were both RA and Dec can be discontinuous.

Instead of reinventing the wheel, we should just use existing functionality in astropy SkyCoord objects to find midpoints and averages between arrays of points.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Jane Morrison on JIRA:

Nadia Dencheva to be clear I am creating a new branch today that will pull wrap_ra into assign WCS and then resample and cube build will import it from there. Later on if we can figure out how to use skycoord instead we just have one place to change it - in assign_wcs. 

Should I assign this ticket to team_coffee and put it my my sprint ?

 

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Nadia Dencheva on JIRA:

Jane Morrison This ticket is about specifically using the SkyCoord object. You can use JP-2076 instead.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Seems like another very-low priority ticket to consider eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants