Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security armoured winter jackets #32823

Closed

Conversation

K-Dynamic
Copy link
Contributor

@K-Dynamic K-Dynamic commented Oct 14, 2024

About the PR

  • Replaces existing instances of security winter jackets with armoured versions that use basic armour vest values.
  • Replaces the security winter jacket in the uniform printer recipe with an unarmoured version.
  • Grammatical changes to descriptions of HoS, warden and security winter jackets.

Why / Balance

Based on #18170 and addresses concerns from #18170 (comment).

Although lizard security officers were already disadvantaged by cold temps, currently all races in security are affected by temperature slowdowns following #29692. Adding armour to security winter jackets brings them to parity with their warden and HoS counterparts.

Technical details

yml changes only

  • Resources/Prototypes/Entities/Clothing/OuterClothing/wintercoats.yml (adds new armour parent to security winter jacket, added security winter jacket without armour with new ID)
  • Resources/Prototypes/Entities/Structures/Machines/lathe.yml (changed uniform printer to only print unarmoured security jacket)
  • Resources/Prototypes/Recipes/Lathes/clothing.yml (changed recipe IDs to print unarmoured security jackets)

Media

Security armoured winter jacket and sources

image
image
image

Security (unarmoured) winter jacket and sources

image
image

Requirements

Changelog

🆑

  • tweak: Security winter jackets in SecDrobes and loadouts are now armoured with basic vest values.
  • tweak: Uniform printer now prints unarmoured security winter jackets.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Oct 14, 2024
@K-Dynamic
Copy link
Contributor Author

K-Dynamic commented Oct 14, 2024

Please note winter jackets making players almost immune to temperature changes is a separate issue and out of scope of this PR.

I might also add insulation to syndicate raid suits and web vests in another PR, no guarantees though.

@K-Dynamic
Copy link
Contributor Author

test fail is related to #31318, not from this PR

@superjj18
Copy link

Can we get armored berets too lol

@K-Dynamic
Copy link
Contributor Author

Can we get armored berets too lol

If you provide an armoured sprite then maybe (someone on Discord said they'd sprite an armoured winter jacket)

@Aisu9
Copy link

Aisu9 commented Oct 15, 2024

isn't durathread only meant to be used for command's clothes?

@thebadman4662
Copy link

isn't durathread only meant to be used for command's clothes?

Its just cloth with plastic, lots of stuff uses it in the fab I recall+ medibeds.

@DieselMohawk
Copy link
Contributor

Can we get armored berets too lol

If you provide an armoured sprite then maybe (someone on Discord said they'd sprite an armoured winter jacket)

That would be me, still need em?

@BolloTea
Copy link

Jackets should not have the full protection of a bulletproof vest to give a jacket. If you want to increase the protection, then make it a little lower. Even a greatcoat or a hos/warden jacket do not have such protection

@thebadman4662
Copy link

Jackets should not have the full protection of a bulletproof vest to give a jacket. If you want to increase the protection, then make it a little lower. Even a greatcoat or a hos/warden jacket do not have such protection

Their jackets very much have full protection, detective coat loses explosive protection though.

@K-Dynamic
Copy link
Contributor Author

K-Dynamic commented Oct 15, 2024

Their jackets very much have full protection, detective coat loses explosive protection though.

Det losing explosive protection is rather dumb (someone specifically put in yml "coat too flimsy" and set coefficient to 1), and even worse I don't think their coats provide insulation

Question is do I open another PR for it or add another commit, even though det coats don't fall under winter jackets

@thebadman4662
Copy link

Pretty sure det coats provide insulation, as they are bane to my 5 second freeze cryopods otherwise. I think even non-winter warden/hos coats do but I might be stripping those out of muscle memory at this point.

@UncaughtEx
Copy link

I've been cryo tanked before with the detectives coat.
It didn't prevent my body temperature from dropping

@thebadman4662
Copy link

I've been cryo tanked before with the detectives coat. It didn't prevent my body temperature from dropping

Non-EVA clothing won't stop you from dropping temperature in well set cryopod but insulation still can greatly increase time before medicine can work, especially boots and coats, scarfs and other clothing have minimal effect if theres any coefficient.

@UncaughtEx
Copy link

I should note my body temperature dropped extremely fast

@K-Dynamic
Copy link
Contributor Author

K-Dynamic commented Oct 16, 2024

Alright rather than adding insulation to detectives coats (and dealing with the headache of adding it to all other coats and the fact HoS/warden already have separated insulated variants), I've elected to just give detectives security winter coats too

Should work as a placeholder until someone specifically sprites a detective insulated coat

@K-Dynamic
Copy link
Contributor Author

K-Dynamic commented Nov 1, 2024

By the way, I have balance concerns on my own PR:

  1. Winter coats have 2x3 internal storage, current armour doesn't (except for syndicate and mercenary vests)
  2. Winter coats fit in 2x2 storage, current armour fits in 4x4
  3. Winter coats pretty much protect against all temp changes

First point can be fixed by simply giving storage to all vests, but would kinda count as powercreep.

Second point could also be fixed by making armour 2x2, also has powercreep concerns (then again armour taking 4x4 space like emergency EVA is a bit silly). I would also reduce internal storage to 2x2 to avoid pocket dimensions. We could also just remove internal storage from outerwear but that would kinda suck.

Third point is (was?) being worked on by another PR that makes it easier to overheat in insulated winter coats.

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Security Area: Security department, including Detectives, HoS size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 19, 2024
@Pumkin69
Copy link
Contributor

Pumkin69 commented Dec 3, 2024

this should be merged and then fix the issues tbh

@github-actions github-actions bot added the size/L Denotes a PR that changes 1000-4999 lines. label Dec 3, 2024
@K-Dynamic
Copy link
Contributor Author

K-Dynamic commented Dec 3, 2024

this should be merged and then fix the issues tbh

Yeah I'm planning to make another PR that resolves most of these issues, as seen by all the commits that I had to revert

@Pumkin69
Copy link
Contributor

Yeah I'm planning to make another PR that resolves most of these issues, as seen by all the commits that I had to revert

yeah good idea

Copy link
Contributor

github-actions bot commented Feb 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 7, 2025
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: UI Changes: Might require knowledge of UI design or code. Changes: Map Changes: Might require knowledge of mapping. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: Audio Changes: Might require knowledge of audio. labels Feb 19, 2025
@K-Dynamic K-Dynamic closed this Feb 19, 2025
@K-Dynamic
Copy link
Contributor Author

Cooked my branch, I'm going to reopen this PR later.

@K-Dynamic K-Dynamic deleted the armoured-winter-jackets branch February 19, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Security Area: Security department, including Detectives, HoS Changes: Audio Changes: Might require knowledge of audio. Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: UI Changes: Might require knowledge of UI design or code. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants