-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security armoured winter jackets #32823
Security armoured winter jackets #32823
Conversation
Please note winter jackets making players almost immune to temperature changes is a separate issue and out of scope of this PR. I might also add insulation to syndicate raid suits and web vests in another PR, no guarantees though. |
test fail is related to #31318, not from this PR |
Can we get armored berets too lol |
If you provide an armoured sprite then maybe (someone on Discord said they'd sprite an armoured winter jacket) |
isn't durathread only meant to be used for command's clothes? |
Its just cloth with plastic, lots of stuff uses it in the fab I recall+ medibeds. |
That would be me, still need em? |
Jackets should not have the full protection of a bulletproof vest to give a jacket. If you want to increase the protection, then make it a little lower. Even a greatcoat or a hos/warden jacket do not have such protection |
Their jackets very much have full protection, detective coat loses explosive protection though. |
Det losing explosive protection is rather dumb (someone specifically put in yml "coat too flimsy" and set coefficient to 1), and even worse I don't think their coats provide insulation Question is do I open another PR for it or add another commit, even though det coats don't fall under winter jackets |
Pretty sure det coats provide insulation, as they are bane to my 5 second freeze cryopods otherwise. I think even non-winter warden/hos coats do but I might be stripping those out of muscle memory at this point. |
I've been cryo tanked before with the detectives coat. |
Non-EVA clothing won't stop you from dropping temperature in well set cryopod but insulation still can greatly increase time before medicine can work, especially boots and coats, scarfs and other clothing have minimal effect if theres any coefficient. |
I should note my body temperature dropped extremely fast |
Alright rather than adding insulation to detectives coats (and dealing with the headache of adding it to all other coats and the fact HoS/warden already have separated insulated variants), I've elected to just give detectives security winter coats too Should work as a placeholder until someone specifically sprites a detective insulated coat |
By the way, I have balance concerns on my own PR:
First point can be fixed by simply giving storage to all vests, but would kinda count as powercreep. Second point could also be fixed by making armour 2x2, also has powercreep concerns (then again armour taking 4x4 space like emergency EVA is a bit silly). I would also reduce internal storage to 2x2 to avoid pocket dimensions. We could also just remove internal storage from outerwear but that would kinda suck. Third point is (was?) being worked on by another PR that makes it easier to overheat in insulated winter coats. |
this should be merged and then fix the issues tbh |
Yeah I'm planning to make another PR that resolves most of these issues, as seen by all the commits that I had to revert |
yeah good idea |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Cooked my branch, I'm going to reopen this PR later. |
About the PR
Why / Balance
Based on #18170 and addresses concerns from #18170 (comment).
Although lizard security officers were already disadvantaged by cold temps, currently all races in security are affected by temperature slowdowns following #29692. Adding armour to security winter jackets brings them to parity with their warden and HoS counterparts.
Technical details
yml changes only
Resources/Prototypes/Entities/Clothing/OuterClothing/wintercoats.yml
(adds new armour parent to security winter jacket, added security winter jacket without armour with new ID)Resources/Prototypes/Entities/Structures/Machines/lathe.yml
(changed uniform printer to only print unarmoured security jacket)Resources/Prototypes/Recipes/Lathes/clothing.yml
(changed recipe IDs to print unarmoured security jackets)Media
Security armoured winter jacket and sources
Security (unarmoured) winter jacket and sources
Requirements
Changelog
🆑