setgamepreset command rework (take two) #30812
Open
+192
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S: Needs Review
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Merge Conflict
SlamBamActionman
added
the
S: Untriaged
eoineoineoin
added
P3: Standard
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read this
I asked the admin team if they have any concerns or requests about this, please do not merge before they had their say
About the PR
repeat of #30756, now without stealthy test fails
setgamepreset command currently changes the game mode permanently* (until reset), despite the help strongly implying that it's only for the current round.
After the change, there is an extra parameter where it can be specified how many rounds the set gamemode should stay, after which it will revert to the server default. If it's only for the next/currently upcoming round the second parameter can be omitted and it will take that as 1.
It is no longer possible to set a different gamemode indefinitely with this command alone, but there are at least two workarounds: either change it for some arbitrary high number, or change the default gamemode cvar (and then change to that game mode to also trigger a reset afterwards)
Why / Balance
Anecdotally I was told that at least one admin finds it annoying that they have to manually change the gamemode back after using the command.
Additionally, there have been multiple unconfirmed reports about the some rare gamemode happening many times in succession, which might all have been instances of this command being used and then forgotten. I have not been given enough actual information to do any investigation on occurences, but if it is in fact real, it would also be resolved by this change
Technical details
The command sends the number of rounds to GameTicker. Every time the round is going through the round end steps it checks if there is currently a countdown going and decreases it by one. When it reaches zero, the game preset is set back to what the default cvar is, and the countdown is set to null