Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atmos unary + sensor yml cleanup #28823

Closed
wants to merge 2 commits into from

Conversation

deltanedas
Copy link
Contributor

About the PR

  • general cleanup of unary piping
  • air vent scrubber and sensor now share the AtmosMonitor components in BaseAtmosMonitor
  • removed access reader from air sensor because nothing used it, its not an air alarm

Why / Balance

copy paste "dont want everything below this" 3 times le bad

Breaking changes

no

Changelog
no cl no fun

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Jun 10, 2024
@deltanedas deltanedas changed the title unary + sensor yml cleanup atmos unary + sensor yml cleanup Jun 10, 2024
@Partmedia Partmedia added the Changes: Atmospherics Code Changes: Might require knowledge of atmospherics code & calculations. label Jun 13, 2024
@deltanedas
Copy link
Contributor Author

09:04:00

@Partmedia so crazy it works

@Partmedia
Copy link
Contributor

It's fine if you don't want to test all of the devices that you touched; you'll just have to wait until I get around to testing them all.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Jun 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Emisse
Copy link
Contributor

Emisse commented Aug 18, 2024

goncflict

@deltanedas deltanedas closed this Aug 19, 2024
@deltanedas deltanedas deleted the sensor-pipe-ops branch August 19, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Atmospherics Code Changes: Might require knowledge of atmospherics code & calculations. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants