Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvised shell crafting recipe #25545

Merged
merged 38 commits into from
Mar 12, 2024
Merged

Improvised shell crafting recipe #25545

merged 38 commits into from
Mar 12, 2024

Conversation

FungiFellow
Copy link
Contributor

@FungiFellow FungiFellow commented Feb 25, 2024 •
edited
Loading

About the PR

I added a Recipe for crafting Improvised Shotgun Shells, Recipe is as follows: 1 Steel, 1 Plastic, 4 Glass Shards, and 6 Matches

Why / Balance

It was added because prior there was no way to obtain ammo for your Improvised Shotgun. There was already a Shell implemented I just added the recipe to craft it.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    image

Breaking changes

Changelog

🆑

  • add: Added Improvised Shotgun Shell Recipe

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Feb 25, 2024
@FungiFellow FungiFellow marked this pull request as draft February 25, 2024 08:06
@Blackern5000
Copy link
Contributor

what if crafting it required a spent shell instead of 1 plastic and 1 steel?

@tutoumi
Copy link

tutoumi commented Feb 25, 2024

this recipy is so biiiiiiiiiiiiig, can't you do like : 1 steel, 1 plastic, 5 glass shard, 8 match sticks. instead of add steel, add plastic, add shard, add shard, add shard, add shard...

@FungiFellow
Copy link
Contributor Author

this recipy is so biiiiiiiiiiiiig, can't you do like : 1 steel, 1 plastic, 5 glass shard, 8 match sticks. instead of add steel, add plastic, add shard, add shard, add shard, add shard...

Glass shards and matchsticks cannot be stacked, so you have to add them individually. For example the Med-Sec Hud recipe has 2 individual capacitors because they can't be stacked

- type: constructionGraph
  id: HudMedSec
  start: start
  graph:
    - node: start
      edges:
        - to: medsecHud
          steps:
            - tag: HudMedical
              name: medical hud
              icon:
                sprite: Clothing/Eyes/Hud/med.rsi
                state: icon
              doAfter: 5
            - tag: HudSecurity
              name: security hud
              icon:
                sprite: Clothing/Eyes/Hud/sec.rsi
                state: icon
              doAfter: 5
            - material: Cable
              amount: 5
              doAfter: 5
            - tag: Radio
              name: radio
              icon:
                sprite: Objects/Devices/communication.rsi
                state: walkietalkie
              doAfter: 5
            - tag: CapacitorStockPart
              name: capacitor
              icon:
                sprite: Objects/Misc/stock_parts.rsi
                state: capacitor
              doAfter: 5
            - tag: CapacitorStockPart
              name: capacitor
              icon:
                sprite: Objects/Misc/stock_parts.rsi
                state: capacitor
              doAfter: 5
    - node: medsecHud
      entity: ClothingEyesHudMedSec

@Brandon-Huu
Copy link
Contributor

Is there a chance for the gun to explode when using these?

@FungiFellow FungiFellow reopened this Feb 29, 2024
@FungiFellow
Copy link
Contributor Author

I found the cause of the Crashing that's kinda dumb

id: ShardGlass
 tags:
      - GlassShard

THE ID AND TAG AREN'T IDENTICAL.

@FungiFellow FungiFellow marked this pull request as ready for review February 29, 2024 09:40
@FungiFellow
Copy link
Contributor Author

Is there a chance for the gun to explode when using these?

Nope, just a very inaccurate shell (45 Degree Spread over the 15 degree of regular shells)

@FungiFellow
Copy link
Contributor Author

Glass shards and matchsticks cannot be stacked

Later on I intend to make Matches able to be butchered into a powder and just use a stack of that instead of 6 individual matches.

But thats for another time

@Dutch-VanDerLinde
Copy link
Contributor

Your changelog be broken you need the CL emoji

@FungiFellow
Copy link
Contributor Author

Your changelog be broken you need the CL emoji

Fixed

@SpeltIncorrectyl
Copy link
Contributor

SpeltIncorrectyl commented Mar 4, 2024 •
edited
Loading

How does it stack up to normal buckshot? The same but more inaccurate?

@FungiFellow
Copy link
Contributor Author

How does it stack up to normal buckshot? The same but more inaccurate?

Same total damage(If you land all pellets), more spread, more pellets but each pellets only does 3/3 slash and pierce.

I performed range tests and effectiveness drops significantly beyond 2.5ish tiles

@metalgearsloth metalgearsloth merged commit 6260e4b into space-wizards:master Mar 12, 2024
8 checks passed
@FungiFellow FungiFellow deleted the Improvised-Shell-Crafting-Recipe branch March 13, 2024 22:57
@SimpleStation14 SimpleStation14 mentioned this pull request Apr 21, 2024
Merged
VMSolidus pushed a commit to Simple-Station/Einstein-Engines that referenced this pull request May 6, 2024
@SimpleStation14 @FungiFellow
Mirror: Improvised shell crafting recipe (#165)
8fd2d6b 
## Mirror of PR #25545: [Improvised shell crafting
recipe](space-wizards/space-station-14#25545)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `6260e4b35b829485149206636861bb7402488724`

PR opened by <img
src="https://avatars.githubusercontent.com/u/151778459?v=4"
width="16"/><a href="https://github.com/FungiFellow"> FungiFellow</a> at
2024-02-25 06:30:06 UTC
PR merged by <img
src="https://avatars.githubusercontent.com/u/19864447?v=4"
width="16"/><a href="https://github.com/web-flow"> web-flow</a> at
2024-03-12 23:52:32 UTC

---

PR changed 4 files with 98 additions and 7 deletions.

The PR had the following labels:
- No C#


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> I added a Recipe for crafting Improvised Shotgun Shells, Recipe is as
follows: 1 Steel, 1 Plastic, 4 Glass Shards, and 6 Matches
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> It was added because prior there was no way to obtain ammo for your
Improvised Shotgun. There was already a Shell implemented I just added
the recipe to craft it.
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
![image](https://github.com/space-wizards/space-station-14/assets/151778459/cbf68907-e710-44ee-836a-1d97e8d30372)
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 🆑
> - add: Added Improvised Shotgun Shell Recipe


</details>

Co-authored-by: FungiFellow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth metalgearsloth approved these changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FungiFellow @Blackern5000 @tutoumi @Brandon-Huu @Dutch-VanDerLinde @SpeltIncorrectyl @metalgearsloth