Shuttle Windows have an invalid node

[EmoGarbage404]

Description

Reproduction

exist and see
Screenshots

Additional context

how was this merged.

[Myctai]

how was this merged.

I guess I gotta set up local build environment to not do that kind of thing... I wanna move onto more difficult things than just messing with YAML.

[Peptide90]

how was this merged.

I guess I gotta set up local build environment to not do that kind of thing... I wanna move onto more difficult things than just messing with YAML.

Huh? If I’m not mistaken they were added in #9306 but don’t have a construction graph, hence shuttleWindow as a node is invalid?

edit: confirmed, there’s no entry in the window graph and no recipe in the main structures file.

[Myctai]

I am not one responsible for shuttle window thing, sorry for offtopic. My theory it's all webedits and untested code to blame.

[Peptide90]

I am not one responsible for shuttle window thing, sorry for offtopic. My theory it's all webedits and untested code to blame.

Not necessarily, there should be a test to pick-up invalid nodes. I believe there is but not it checks the construction graph, not the entity for non existent nodes.

The easy fix to this is just remove the construction component from the shuttle window, the more in depth fix is to add the node to the graph which is pretty simple too. Haven’t checked if shuttle walls are constructible or if they’re even intended to be.

[Myctai]

Haven’t checked if shuttle walls are constructible or if they’re even intended to be.

On tgstation shuttle walls are merely titanium walls, you can make new ones easily. At least it used to be like that.

[Ablankmann]

I am not one responsible for shuttle window thing, sorry for offtopic. My theory it's all webedits and untested code to blame.

Not necessarily, there should be a test to pick-up invalid nodes. I believe there is but not it checks the construction graph, not the entity for non existent nodes.

The easy fix to this is just remove the construction component from the shuttle window, the more in depth fix is to add the node to the graph which is pretty simple too. Haven’t checked if shuttle walls are constructible or if they’re even intended to be.

They're not supposed to be able to be created until we get titanium

[Myctai]

Might want to just make them equal to normal walls, made with steel. Freedom to shuttle builders! But hold on, how do you make girder slapped with steel turn into shuttle wall?..

[Peptide90]

Might want to just make them equal to normal walls, made with steel. Freedom to shuttle builders! But hold on, how do you make girder slapped with steel turn into shuttle wall?..

The issue is people potentially deconstructing the proper shuttles but hey ho. For construction I recommend the page on the development wiki. Essentially you’ll need a new node for the thing you want with steps different to the ones to make a normal wall. Otherwise you’ll need a new graph. We’re mimicking TG construction steps as much as possible.

[Ablankmann]

Might want to just make them equal to normal walls, made with steel. Freedom to shuttle builders! But hold on, how do you make girder slapped with steel turn into shuttle wall?..

This would have to be done for shuttle walls as well, since they are exactly like the windows as they're made with titanium
And, because we don't HAVE that... They can't be made either.

[mirrorcult]

shuttle windows shouldn't be constructible same with walls

[Myctai]

The issue is people potentially deconstructing the proper shuttles

Well, it would be paying attention to dork with lit welder and doafter above their head to mitigate that. I don't have much faith in players tho, I could do the doafter thing with C4 brick planting just fine.

[Ablankmann]

The issue is people potentially deconstructing the proper shuttles

Well, it would be paying attention to dork with lit welder and doafter above their head to mitigate that. I don't have much faith in players tho, I could do the doafter thing with C4 brick planting just fine.

Meh, I would wait until we have the proper materials for shuttle stuff to be added before we make them constructable