Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nukies mode is broken (again) #9132

Closed
Ablankmann opened this issue Jun 24, 2022 · 1 comment · Fixed by #9159
Closed

Nukies mode is broken (again) #9132

Ablankmann opened this issue Jun 24, 2022 · 1 comment · Fixed by #9159
Labels
D2: Medium Difficulty: A good amount of codebase knowledge required. Issue: Replicated This issue has been replicated by another user. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes

Comments

@Ablankmann
Copy link
Contributor

Description

The nukies mode is broken. Like, completely unplayable. It won't start.

Reproduction

Start a server, addgamerule NukeOps to make the next mode nukies
Wait for game to start
When the counter reaches 0 and starts the game, you should notice the round restarts immediety after.

Additional context

The bug completely borks nukies in Secret, not just the NukeOps mode. Please fix funny red spessmen mode no worke.

@Mirino97 Mirino97 added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D2: Medium Difficulty: A good amount of codebase knowledge required. Issue: Replicated This issue has been replicated by another user. labels Jun 25, 2022
@Mirino97
Copy link
Contributor

I may have a fix for this up soon, but in case I don't, here's what I discovered.
Bug:
image

Issue found:
In NukeopsRuleSystem, in the spawn method, there's:

foreach (var uid in _stationSystem.Stations)
        {
            var grid = Comp<IMapGridComponent>(uid).Grid;

            aabb = aabb?.Union(grid.WorldAABB) ?? grid.WorldAABB;
        }

In Moony's words: "that is in fact the wrong entity
stations are an abstract datum
you want to iterate the grids that compose the station."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D2: Medium Difficulty: A good amount of codebase knowledge required. Issue: Replicated This issue has been replicated by another user. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants