Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrivals can delete the nuke #30555

Closed
Ilya246 opened this issue Aug 1, 2024 · 1 comment · Fixed by #33659
Closed

arrivals can delete the nuke #30555

Ilya246 opened this issue Aug 1, 2024 · 1 comment · Fixed by #33659
Labels
D2: Medium Difficulty: A good amount of codebase knowledge required. T: Bugfix Type: Bugs and/or bugfixes

Comments

@Ilya246
Copy link
Contributor

Ilya246 commented Aug 1, 2024

Description

title

Reproduction

  1. nuke
  2. drag it over arrival arrival spot
  3. wait for it to arrival
  4. no nuke

Screenshots
happened in round #61353
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Aug 1, 2024
@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Aug 2, 2024 •
edited
Loading

hmmm. This ones a little more involved because if you wanted to use SpecialRespawn on the nuke it needs to have the same ID and code. and would still probably mess up pinpointers.

Maybe it would be better to try to catch the deletion as an event and teleport it back to station?

@IProduceWidgets IProduceWidgets added T: Bugfix Type: Bugs and/or bugfixes D2: Medium Difficulty: A good amount of codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 2, 2024
@GansuLalan GansuLalan mentioned this issue Nov 29, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D2: Medium Difficulty: A good amount of codebase knowledge required. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for arrivals deleting nuke GansuLalan/space-station-14
2 participants
@Ilya246 @IProduceWidgets