Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stations can not reasonably be refilled after minor-major atmos loss. #29525

Open
Titian3 opened this issue Jun 28, 2024 · 4 comments
Open

Stations can not reasonably be refilled after minor-major atmos loss. #29525

Titian3 opened this issue Jun 28, 2024 · 4 comments
Labels
Changes: Atmospherics Code Changes: Might require knowledge of atmospherics code & calculations. D1: High Difficulty: Extensive codebase knowledge required. T: Bugfix Type: Bugs and/or bugfixes

Comments

@Titian3
Copy link
Member

Titian3 commented Jun 28, 2024

Description

This recent PR: #28909 Has made it so if the pressure drops then vents go in to a lockout mode to stop air refilling after a spacing and not wasting air from distro.
But to have them allow to push gas out again you are required to on the air alarm change the mode to fill.
When there is a mass venting situation It is not a reasonable expectation that all of these alarms would have someone go to and do the fill option.

Reproduction

  • Vent station
  • See pressure lockout.
  • Manually fill from airlock.

Screenshots
image
image

Additional context
Seen a couple of times now, Doubt if education or additional access to these air sensors it would be able to solve it. Might need to have some form of mass action or trigger where the lockout would come off?

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Jun 28, 2024
@Titian3
Copy link
Member Author

Titian3 commented Jun 28, 2024

Might not be much of a problem after observing it for another day, will probably close this soon. Seems like its only issue when mass sections have low pressure.

@IProduceWidgets IProduceWidgets added T: Bugfix Type: Bugs and/or bugfixes D1: High Difficulty: Extensive codebase knowledge required. Issue: Replicated This issue has been replicated by another user. Changes: Atmospherics Code Changes: Might require knowledge of atmospherics code & calculations. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Issue: Replicated This issue has been replicated by another user. labels Jun 29, 2024
@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Jun 29, 2024

> Me when I assign the tags before I scroll all the way down.

@osjarw
Copy link
Contributor

osjarw commented Jun 29, 2024

You mentioned wrong PR, that PR added the override to the UnderPressureLockout(UPLO) so people could just set Fill mode instead of having to run around opening doors and/or bringing canisters to raise the pressure.

The UnderPressureLockout that you're speaking of was added in #9824 ,
The reason this has become a problem was because the UPLO was set to 80kPa in #29504 , which is a temporary fix to get rid of the situation where this lockout doesn't get triggered at all.

Currently I have a PR which should get rid of this problem, after that gets merged the UPLO will be set back to some reasonable level, so opening doors has a good chance of repressurizing rooms.

@Quantum-cross
Copy link

Please take a look at this draft I just whipped up: #35489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Atmospherics Code Changes: Might require knowledge of atmospherics code & calculations. D1: High Difficulty: Extensive codebase knowledge required. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

No branches or pull requests

4 participants