Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ore and Plants Bags are broken #27208

Closed
Vermidia opened this issue Apr 21, 2024 · 6 comments · Fixed by #27234 or #27601
Closed

Ore and Plants Bags are broken #27208

Vermidia opened this issue Apr 21, 2024 · 6 comments · Fixed by #27234 or #27601
Labels
Issue: Replicated This issue has been replicated by another user. T: Bugfix Type: Bugs and/or bugfixes

Comments

@Vermidia
Copy link
Contributor

Vermidia commented Apr 21, 2024

Description

They can no longer do individual or area pickups.

Reproduction

Try to use a plant bag on plants or an ore bag on ores

Screenshots

Additional context

Fails on UseDelay.TryResetDelay, though unlike the Bible one I'm not sure exactly why here.

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Apr 21, 2024
@UbaserB UbaserB added T: Bugfix Type: Bugs and/or bugfixes Issue: Replicated This issue has been replicated by another user. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Apr 21, 2024
@UbaserB
Copy link
Member

UbaserB commented Apr 21, 2024

Had this happen to me ingame for the plant bag

@Tayrtahn
Copy link
Member

Turns out Server's StorageSystem and SharedStorageSystem are both using UseDelay for separate purposes (UI opening sound spam prevention and quick/area pickup cooldown).

@Erisfiregamer1
Copy link
Contributor

Still happening, I can't area pickup or quick pickup with plant bags. Was this behaviour removed?

@Vermidia
Copy link
Contributor Author

Vermidia commented May 1, 2024

I think it's still bugged and not intended to be removed.

@Erisfiregamer1
Copy link
Contributor

Yeah, still bugged. Reopen, linked PR did not fix

@UbaserB UbaserB reopened this May 2, 2024
@Tayrtahn
Copy link
Member

Tayrtahn commented May 2, 2024

Yeah, I actually only tested it with trash bags and assumed it fixed ore bags and plant bags too. Had a feeling that would come back to bite me.

Anyway, the issue is that the bags don't have a UseDelay component, and Storage needs one for the insert cooldown. It'd be easy enough to add them to the prototypes, but I suspect that this issue will come up again, since it's not obvious that Storage requires UseDelay to function. I might modify UseDelay.SetLength to add the component if the entity doesn't have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Replicated This issue has been replicated by another user. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
4 participants