Apply RoleLoadout MinLimit fix to EnsureValid too (#29358)

Apply MinLimit fix to EnsureValid too
space-wizards · Jun 23, 2024 · c2f8984 · c2f8984
1 parent 0546c9b
commit c2f8984
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/Content.Shared/Preferences/Loadouts/RoleLoadout.cs b/Content.Shared/Preferences/Loadouts/RoleLoadout.cs
@@ -124,9 +124,12 @@ public void EnsureValid(HumanoidCharacterProfile profile, ICommonSession session
             // If you put invalid ones first but that's your fault for not using sensible defaults
             if (loadouts.Count < groupProto.MinLimit)
             {
-                for (var i = 0; i < Math.Min(groupProto.MinLimit, groupProto.Loadouts.Count); i++)
+                foreach (var protoId in groupProto.Loadouts)
                 {
-                    if (!protoManager.TryIndex(groupProto.Loadouts[i], out var loadoutProto))
+                    if (loadouts.Count >= groupProto.MinLimit)
+                        break;
+
+                    if (!protoManager.TryIndex(protoId, out var loadoutProto))
                         continue;
 
                     var defaultLoadout = new Loadout()
@@ -193,11 +196,10 @@ public void SetDefault(HumanoidCharacterProfile? profile, ICommonSession? sessio
             if (groupProto.MinLimit > 0)
             {
                 // Apply any loadouts we can.
-                var addedCount = 0;
                 foreach (var protoId in groupProto.Loadouts)
                 {
                     // Reached the limit, time to stop
-                    if (addedCount >= groupProto.MinLimit)
+                    if (loadouts.Count >= groupProto.MinLimit)
                         break;
 
                     if (!protoManager.TryIndex(protoId, out var loadoutProto))
@@ -214,7 +216,6 @@ public void SetDefault(HumanoidCharacterProfile? profile, ICommonSession? sessio
 
                     loadouts.Add(defaultLoadout);
                     Apply(loadoutProto);
-                    addedCount++;
                 }
             }
         }