feat: Add aggregate offset support #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
Codecov Report
@@ Coverage Diff @@
## develop #778 +/- ##
===========================================
+ Coverage 58.60% 58.72% +0.11%
===========================================
Files 152 153 +1
Lines 17056 17120 +64
===========================================
+ Hits 9995 10053 +58
- Misses 6125 6129 +4
- Partials 936 938 +2
|
shahzadlone
approved these changes
Sep 8, 2022
Docs need to be treated differently else they will be offsetted twice (applied on select, then again here).
AndrewSisley
force-pushed
the
sisley/feat/I379-agg-offset
branch
from
7efd97b to
b46aab7
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Use const over string for offset * Add enumerable skip support * Add offset support for inline array count * Add offset support for inline array numeric aggs * Add offset support for relation counts Docs need to be treated differently else they will be offsetted twice (applied on select, then again here). * Add offset support for relation numeric aggs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #379
Description
Adds offset support for aggregates. Also introduces a new enumerable type.
Specify the platform(s) on which this was tested: