Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tests for offset only #620

Closed
AndrewSisley opened this issue Jul 11, 2022 · 1 comment · Fixed by #706
Closed

No tests for offset only #620

AndrewSisley opened this issue Jul 11, 2022 · 1 comment · Fixed by #706
Assignees
@fredcarle
Labels
area/testing Related to any test or testing suite
Milestone
DefraDB v0.3.1

Comments

@AndrewSisley
Copy link
Contributor

Spotted in #614

We have no tests covering the use of offset without a limit, e.g.:

query {
   user(offset: 2) {
       ...
   }
}
@AndrewSisley AndrewSisley added the area/testing Related to any test or testing suite label Jul 11, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3.1 milestone Jul 11, 2022
@AndrewSisley AndrewSisley mentioned this issue Jul 11, 2022
Merged
4 tasks
@fredcarle fredcarle self-assigned this Aug 5, 2022
@fredcarle fredcarle mentioned this issue Aug 5, 2022
Merged
4 tasks
@fredcarle
Copy link
Collaborator

Closed by #706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/testing Related to any test or testing suite
Projects
None yet
Milestone
DefraDB v0.3.1
2 participants
@fredcarle @AndrewSisley