Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Test filter in filter tests #473

Merged
merged 1 commit into from
May 27, 2022
Merged

test: Test filter in filter tests #473

merged 1 commit into from
May 27, 2022

Conversation

AndrewSisley
Copy link
Contributor

RELEVANT ISSUE(S)

Resolves #472

DESCRIPTION

Previously filter tests would pass if the filter does nothing (i.e. filter code was non-existant), as the full set of data was expected to be returned, this PR adds records to be filtered out by test queries causing them to fail should the filter not run.

HOW HAS THIS BEEN TESTED?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

CHECKLIST:

  • I have commented the code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the repo-held documentation.
  • I have made sure that the PR title adheres to the conventional commit style (subset of the ones we use can be found under: tools/configs/chglog/config.yml

ENVIRONMENT / OS THIS WAS TESTED ON?

Please specify which of the following was this tested on (remove or add your own):

  • Arch Linux
  • Debian Linux
  • MacOS
  • Windows

@AndrewSisley
Test filter in filter tests
6350935 
Previously filter tests would pass if the filter does nothing (i.e. filter code was non-existant), as the full set of data was expected to be returned
@AndrewSisley AndrewSisley added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality labels May 26, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3 milestone May 26, 2022
@AndrewSisley AndrewSisley self-assigned this May 26, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 111 Benchmarks were ✅ Better.
  • 2 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4274ms ± 0%216ms ± 0%−21.20%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.3ms ± 0%9.7ms ± 0%−5.34%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4100ms ± 0%98ms ± 0%−2.39%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.01s ± 0%0.96s ± 0%−4.92%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.8ms ± 0%43.8ms ± 0%−6.42%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4467ms ± 0%436ms ± 0%−6.67%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.75s ± 0%4.44s ± 0%−6.66%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4421µs ± 0%340µs ± 0%−19.10%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.89ms ± 0%3.52ms ± 0%−9.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.5ms ± 0%38.3ms ± 0%−5.34%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4402µs ± 0%354µs ± 0%−11.86%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.02ms ± 0%3.68ms ± 0%−8.31%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4251µs ± 0%247µs ± 0%−1.31%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.87ms ± 0%1.77ms ± 0%−5.17%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-425.5ms ± 0%22.7ms ± 0%−11.08%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4270µs ± 0%259µs ± 0%−3.82%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.91ms ± 0%1.78ms ± 0%−6.75%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.23ms ± 0%1.16ms ± 0%−5.44%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-410.3ms ± 0%9.6ms ± 0%−6.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4444µs ± 0%408µs ± 0%−8.06%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.36ms ± 0%1.28ms ± 0%−6.43%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.8ms ± 0%10.3ms ± 0%−4.73%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4446µs ± 0%376µs ± 0%−15.64%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4512µs ± 0%425µs ± 0%−17.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4469µs ± 0%431µs ± 0%−8.20%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4757µs ± 0%623µs ± 0%−17.77%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4737µs ± 0%626µs ± 0%−15.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4704µs ± 0%649µs ± 0%−7.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4296µs ± 0%270µs ± 0%−8.62%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4278µs ± 0%272µs ± 0%−2.28%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4288µs ± 0%270µs ± 0%−6.31%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4494µs ± 0%403µs ± 0%−18.42%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.55ms ± 0%1.37ms ± 0%−11.34%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-413.3ms ± 0%12.3ms ± 0%−7.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-413.6µs ± 0%12.5µs ± 0%−7.90%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.4µs ± 0%13.3µs ± 0%−7.30%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-415.9µs ± 0%15.2µs ± 0%−4.27%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.1µs ± 0%19.0µs ± 0%−5.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4132µs ± 0%123µs ± 0%−6.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4140µs ± 0%129µs ± 0%−7.61%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4146µs ± 0%137µs ± 0%−5.65%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4170µs ± 0%152µs ± 0%−10.39%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4202µs ± 0%191µs ± 0%−5.21%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-417.7µs ± 0%14.5µs ± 0%−18.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.4µs ± 0%15.0µs ± 0%−13.93%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-420.0µs ± 0%15.3µs ± 0%−23.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-422.2µs ± 0%16.8µs ± 0%−24.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-423.8µs ± 0%20.1µs ± 0%−15.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4165µs ± 0%128µs ± 0%−22.12%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4156µs ± 0%141µs ± 0%−9.40%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4167µs ± 0%146µs ± 0%−12.77%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4183µs ± 0%158µs ± 0%−13.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4212µs ± 0%195µs ± 0%−8.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-446.7µs ± 0%43.5µs ± 0%−6.90%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-458.2µs ± 0%44.1µs ± 0%−24.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-453.2µs ± 0%48.0µs ± 0%−9.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-461.0µs ± 0%52.2µs ± 0%−14.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-470.0µs ± 0%65.3µs ± 0%−6.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4399µs ± 0%336µs ± 0%−15.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4381µs ± 0%344µs ± 0%−9.70%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4397µs ± 0%358µs ± 0%−9.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4432µs ± 0%404µs ± 0%−6.68%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4536µs ± 0%484µs ± 0%−9.66%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-447.8µs ± 0%46.5µs ± 0%−2.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-462.1µs ± 0%56.0µs ± 0%−9.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-471.8µs ± 0%68.0µs ± 0%−5.33%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4426µs ± 0%368µs ± 0%−13.62%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4452µs ± 0%371µs ± 0%−17.77%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4445µs ± 0%369µs ± 0%−17.22%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4483µs ± 0%426µs ± 0%−11.87%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4563µs ± 0%495µs ± 0%−12.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4142µs ± 0%120µs ± 0%−15.76%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4144µs ± 0%121µs ± 0%−15.54%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4156µs ± 0%120µs ± 0%−23.46%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4151µs ± 0%131µs ± 0%−13.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4165µs ± 0%147µs ± 0%−10.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.40ms ± 0%1.22ms ± 0%−13.38%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.50ms ± 0%1.19ms ± 0%−20.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.63ms ± 0%1.24ms ± 0%−23.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.50ms ± 0%1.24ms ± 0%−17.37%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.80ms ± 0%1.39ms ± 0%−22.94%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4127µs ± 0%115µs ± 0%−9.90%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4135µs ± 0%113µs ± 0%−16.41%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4141µs ± 0%116µs ± 0%−18.12%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4145µs ± 0%121µs ± 0%−16.56%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4142µs ± 0%131µs ± 0%−7.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.16ms ± 0%1.16ms ± 0%−0.62%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.37ms ± 0%1.16ms ± 0%−15.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.36ms ± 0%1.20ms ± 0%−12.17%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.50ms ± 0%1.20ms ± 0%−20.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.61ms ± 0%1.36ms ± 0%−15.68%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.74µs ± 0%8.14µs ± 0%−6.80%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-410.5µs ± 0%8.6µs ± 0%−18.03%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-411.1µs ± 0%9.1µs ± 0%−18.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-413.1µs ± 0%10.7µs ± 0%−18.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-418.2µs ± 0%14.6µs ± 0%−19.90%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4110µs ± 0%92µs ± 0%−16.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4132µs ± 0%88µs ± 0%−33.73%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4116µs ± 0%92µs ± 0%−21.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4122µs ± 0%109µs ± 0%−11.03%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4167µs ± 0%144µs ± 0%−14.31%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4127µs ± 0%124µs ± 0%−2.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4140µs ± 0%125µs ± 0%−10.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4131µs ± 0%122µs ± 0%−7.08%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4138µs ± 0%126µs ± 0%−8.23%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4139µs ± 0%132µs ± 0%−5.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.29ms ± 0%1.22ms ± 0%−5.70%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.31ms ± 0%1.19ms ± 0%−8.71%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.39ms ± 0%1.19ms ± 0%−14.60%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.36ms ± 0%1.23ms ± 0%−9.66%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.49ms ± 0%1.31ms ± 0%−11.92%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.6µs ± 0%46.3µs ± 0%+1.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-448.6µs ± 0%49.8µs ± 0%+2.50%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.4ms ± 0%10.4ms ± 0%−9.25%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4274ms ± 0%216ms ± 0%−21.20%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.3ms ± 0%9.7ms ± 0%−5.34%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4100ms ± 0%98ms ± 0%−2.39%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.01s ± 0%0.96s ± 0%−4.92%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.8ms ± 0%43.8ms ± 0%−6.42%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4467ms ± 0%436ms ± 0%−6.67%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.75s ± 0%4.44s ± 0%−6.66%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4421µs ± 0%340µs ± 0%−19.10%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.89ms ± 0%3.52ms ± 0%−9.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.5ms ± 0%38.3ms ± 0%−5.34%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4402µs ± 0%354µs ± 0%−11.86%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.02ms ± 0%3.68ms ± 0%−8.31%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4251µs ± 0%247µs ± 0%−1.31%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.87ms ± 0%1.77ms ± 0%−5.17%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-425.5ms ± 0%22.7ms ± 0%−11.08%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4270µs ± 0%259µs ± 0%−3.82%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.91ms ± 0%1.78ms ± 0%−6.75%(p=1.000 n=1+1)
pkg:query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4372µs ± 0%348µs ± 0%−6.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.23ms ± 0%1.16ms ± 0%−5.44%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-410.3ms ± 0%9.6ms ± 0%−6.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4444µs ± 0%408µs ± 0%−8.06%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.36ms ± 0%1.28ms ± 0%−6.43%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.8ms ± 0%10.3ms ± 0%−4.73%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4446µs ± 0%376µs ± 0%−15.64%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4512µs ± 0%425µs ± 0%−17.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4469µs ± 0%431µs ± 0%−8.20%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4757µs ± 0%623µs ± 0%−17.77%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4737µs ± 0%626µs ± 0%−15.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4704µs ± 0%649µs ± 0%−7.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4296µs ± 0%270µs ± 0%−8.62%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4278µs ± 0%272µs ± 0%−2.28%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4288µs ± 0%270µs ± 0%−6.31%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4494µs ± 0%403µs ± 0%−18.42%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.55ms ± 0%1.37ms ± 0%−11.34%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-413.3ms ± 0%12.3ms ± 0%−7.56%(p=1.000 n=1+1)
pkg:storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-413.3µs ± 0%12.4µs ± 0%−6.99%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-413.6µs ± 0%12.5µs ± 0%−7.90%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.4µs ± 0%13.3µs ± 0%−7.30%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-415.9µs ± 0%15.2µs ± 0%−4.27%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.1µs ± 0%19.0µs ± 0%−5.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4132µs ± 0%123µs ± 0%−6.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4140µs ± 0%129µs ± 0%−7.61%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4146µs ± 0%137µs ± 0%−5.65%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4170µs ± 0%152µs ± 0%−10.39%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4202µs ± 0%191µs ± 0%−5.21%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-417.7µs ± 0%14.5µs ± 0%−18.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.4µs ± 0%15.0µs ± 0%−13.93%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-420.0µs ± 0%15.3µs ± 0%−23.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-422.2µs ± 0%16.8µs ± 0%−24.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-423.8µs ± 0%20.1µs ± 0%−15.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4165µs ± 0%128µs ± 0%−22.12%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4156µs ± 0%141µs ± 0%−9.40%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4167µs ± 0%146µs ± 0%−12.77%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4183µs ± 0%158µs ± 0%−13.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4212µs ± 0%195µs ± 0%−8.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-446.7µs ± 0%43.5µs ± 0%−6.90%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-458.2µs ± 0%44.1µs ± 0%−24.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-453.2µs ± 0%48.0µs ± 0%−9.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-461.0µs ± 0%52.2µs ± 0%−14.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-470.0µs ± 0%65.3µs ± 0%−6.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4399µs ± 0%336µs ± 0%−15.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4381µs ± 0%344µs ± 0%−9.70%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4397µs ± 0%358µs ± 0%−9.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4432µs ± 0%404µs ± 0%−6.68%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4536µs ± 0%484µs ± 0%−9.66%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.6µs ± 0%46.3µs ± 0%+1.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-447.8µs ± 0%46.5µs ± 0%−2.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-448.6µs ± 0%49.8µs ± 0%+2.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-462.1µs ± 0%56.0µs ± 0%−9.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-471.8µs ± 0%68.0µs ± 0%−5.33%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4426µs ± 0%368µs ± 0%−13.62%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4452µs ± 0%371µs ± 0%−17.77%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4445µs ± 0%369µs ± 0%−17.22%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4483µs ± 0%426µs ± 0%−11.87%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4563µs ± 0%495µs ± 0%−12.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4142µs ± 0%120µs ± 0%−15.76%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4144µs ± 0%121µs ± 0%−15.54%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4156µs ± 0%120µs ± 0%−23.46%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4151µs ± 0%131µs ± 0%−13.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4165µs ± 0%147µs ± 0%−10.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.40ms ± 0%1.22ms ± 0%−13.38%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.50ms ± 0%1.19ms ± 0%−20.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.63ms ± 0%1.24ms ± 0%−23.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.50ms ± 0%1.24ms ± 0%−17.37%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.80ms ± 0%1.39ms ± 0%−22.94%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4127µs ± 0%115µs ± 0%−9.90%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4135µs ± 0%113µs ± 0%−16.41%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4141µs ± 0%116µs ± 0%−18.12%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4145µs ± 0%121µs ± 0%−16.56%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4142µs ± 0%131µs ± 0%−7.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.16ms ± 0%1.16ms ± 0%−0.62%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.37ms ± 0%1.16ms ± 0%−15.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.36ms ± 0%1.20ms ± 0%−12.17%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.50ms ± 0%1.20ms ± 0%−20.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.61ms ± 0%1.36ms ± 0%−15.68%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.74µs ± 0%8.14µs ± 0%−6.80%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-410.5µs ± 0%8.6µs ± 0%−18.03%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-411.1µs ± 0%9.1µs ± 0%−18.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-413.1µs ± 0%10.7µs ± 0%−18.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-418.2µs ± 0%14.6µs ± 0%−19.90%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4110µs ± 0%92µs ± 0%−16.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4132µs ± 0%88µs ± 0%−33.73%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4116µs ± 0%92µs ± 0%−21.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4122µs ± 0%109µs ± 0%−11.03%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4167µs ± 0%144µs ± 0%−14.31%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4127µs ± 0%124µs ± 0%−2.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4140µs ± 0%125µs ± 0%−10.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4131µs ± 0%122µs ± 0%−7.08%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4138µs ± 0%126µs ± 0%−8.23%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4139µs ± 0%132µs ± 0%−5.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.29ms ± 0%1.22ms ± 0%−5.70%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.31ms ± 0%1.19ms ± 0%−8.71%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.39ms ± 0%1.19ms ± 0%−14.60%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.36ms ± 0%1.23ms ± 0%−9.66%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.49ms ± 0%1.31ms ± 0%−11.92%(p=1.000 n=1+1)
 

shahzadlone
shahzadlone approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewSisley AndrewSisley merged commit e9dd956 into develop May 27, 2022
@AndrewSisley AndrewSisley deleted the sisley/fix/I472-filter-tests branch May 27, 2022 14:15
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
test: Test filter in filter tests (sourcenetwork#473)
85a56fe 
Previously filter tests would pass if the filter does nothing (i.e. filter code was non-existent), as the full set of data was expected to be returned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

@orpheuslummis orpheuslummis Awaiting requested review from orpheuslummis

@fredcarle fredcarle Awaiting requested review from fredcarle

Assignees

@AndrewSisley AndrewSisley

Labels
ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Simple filter tests do not test filter
3 participants
@AndrewSisley @source-devs @shahzadlone