fix: Issue preventing DB from restarting with no records #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimnz
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #437 +/- ##
========================================
Coverage 65.66% 65.67%
========================================
Files 80 80
Lines 9481 9480 -1
========================================
Hits 6226 6226
+ Misses 2624 2623 -1
Partials 631 631
|
shahzadlone
approved these changes
May 13, 2022
AndrewSisley
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #386
Simple fix.
GetAllDocKeysreturns a channel that will return results, but the same func also discards the transaction in a defer statement, which gets called after the return of the channel.Moved the transaction discard into the cleanup routine of the subprocedure that handles the original channel cleanup.