Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename NewCidV1_SHA2_256 to mixedCaps #415

Merged
merged 1 commit into from
May 6, 2022

Conversation

fredcarle
Copy link
Collaborator

Resolves #414

A small style change to make NewCidV1_SHA2_256 more idiomatic.

@fredcarle fredcarle added code quality Related to improving code quality action/no-benchmark Skips the action that runs the benchmark. labels May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #415 (312214d) into develop (222bf6d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #415   +/-   ##
========================================
  Coverage    65.63%   65.63%           
========================================
  Files           80       80           
  Lines         9463     9463           
========================================
  Hits          6211     6211           
  Misses        2622     2622           
  Partials       630      630           
Impacted Files Coverage Δ
core/cid.go 100.00% <100.00%> (ø)
db/collection.go 56.07% <100.00%> (ø)

@fredcarle fredcarle added this to the DefraDB v0.3 milestone May 6, 2022
@fredcarle fredcarle self-assigned this May 6, 2022
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly like our discussion, LGTM!

@fredcarle fredcarle changed the title style: Rename NewCidV1_SHA2_256 to mixedCaps refactor: Rename NewCidV1_SHA2_256 to mixedCaps May 6, 2022
@fredcarle fredcarle merged commit 89e58dd into develop May 6, 2022
@fredcarle fredcarle deleted the fredcarle/style/I414-rename-NewCidV1_SHA2_256 branch May 6, 2022 18:10
fredcarle added a commit that referenced this pull request May 6, 2022
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename NewCidV1_SHA2_256
2 participants