Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract errors to errors.go #257

Closed
Tracked by #488
jsimnz opened this issue Mar 1, 2022 · 4 comments
Closed
Tracked by #488

Extract errors to errors.go #257

jsimnz opened this issue Mar 1, 2022 · 4 comments
Assignees
@fredcarle
Labels
area/errors Related to the internal management or design of our error handling system feature New feature or request

Comments

@jsimnz
Copy link
Member

jsimnz commented Mar 1, 2022 •
edited by AndrewSisley
Loading

Part of #488

Sometimes our error message suck. Lets fix that.
@jsimnz jsimnz added feature New feature or request area/errors Related to the internal management or design of our error handling system labels Mar 1, 2022
@jsimnz jsimnz added this to the DefraDB v0.3 milestone Mar 1, 2022
@AndrewSisley AndrewSisley mentioned this issue Jun 23, 2022
Closed
@jsimnz jsimnz modified the milestones: DefraDB v0.3.1, DefraDB v0.4 Sep 13, 2022
@jsimnz jsimnz mentioned this issue Sep 20, 2022
Closed
@fredcarle
Copy link
Collaborator

@jsimnz Please add more context :)

@AndrewSisley AndrewSisley self-assigned this Dec 14, 2022
@AndrewSisley AndrewSisley changed the title Better Error display/response Extract errors to errors.go Dec 14, 2022
This was referenced Dec 14, 2022
Merged
Merged
Merged
Merged
@AndrewSisley AndrewSisley modified the milestones: DefraDB v0.4, DefraDB v0.5 Dec 20, 2022
@AndrewSisley AndrewSisley mentioned this issue Jan 16, 2023
Merged
@AndrewSisley
Copy link
Contributor

Note, to find errors defined outside of tests and errors.go files search for errors.New(, excluding files *_test.go, *errors.go

This was referenced Jan 16, 2023
Merged
Merged
@AndrewSisley AndrewSisley removed their assignment Jan 18, 2023
@orpheuslummis orpheuslummis mentioned this issue Feb 15, 2023
Merged
4 tasks
@orpheuslummis
Copy link
Contributor

net and node are not done yet, at least

@jsimnz jsimnz modified the milestones: DefraDB v0.5, DefraDB v0.6 Mar 20, 2023
@jsimnz jsimnz mentioned this issue Mar 23, 2023
Closed
@fredcarle fredcarle modified the milestones: DefraDB v0.6, DefraDB v0.5.1 May 4, 2023
@fredcarle fredcarle modified the milestones: DefraDB v0.5.1, DefraDB v0.6 May 4, 2023
@fredcarle fredcarle self-assigned this May 29, 2023
@fredcarle fredcarle modified the milestones: DefraDB v0.6, DefraDB v0.7 Jun 27, 2023
@fredcarle
Copy link
Collaborator

I think most of it has been done. Lets keep an eye out for this in review from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/errors Related to the internal management or design of our error handling system feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@orpheuslummis @jsimnz @fredcarle @AndrewSisley