Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add rule to only run benchmark if other check are successful #194

Merged
merged 3 commits into from
Feb 14, 2022
Merged

ci: Add rule to only run benchmark if other check are successful #194

merged 3 commits into from
Feb 14, 2022

Conversation

shahzadlone
Copy link
Member

Add a check to only run the benchmark ec2 runner workflow if the other GitHub workflows are successful.

@shahzadlone shahzadlone added perf Performance issue or suggestion area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. labels Feb 8, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.2.1 milestone Feb 8, 2022
@shahzadlone shahzadlone self-assigned this Feb 8, 2022
@shahzadlone
Ready to test, but github actions for workflow runs dependent on each
a7a3b1f 
other only work on default branches apparently.
@shahzadlone shahzadlone force-pushed the lone/tools/run-bench-on-ec2 branch from 0f28631 to a7a3b1f Compare February 8, 2022 12:03
@shahzadlone
Copy link
Member Author

shahzadlone commented Feb 8, 2022 •
edited
Loading

Because I am trying to use the workflow_run so I don't have to have all the workflows in one giant file, git-hub actions actually has this weird thing where it only runs the workflow_run rules on the default branch.

I can merge this in and we can see if the benchmark CI gets triggered or not (it's not in the PR).

OR I can make one giant github workflow for all the rules so I can declare them with needs rule to easily mark serialized dependency.

@shahzadlone shahzadlone requested a review from jsimnz February 8, 2022 18:24
@shahzadlone shahzadlone linked an issue Feb 8, 2022 that may be closed by this pull request
Integrate new benchmark suite to the CI system #176
Closed
@jsimnz
Copy link
Member

jsimnz commented Feb 9, 2022

From what I can tell, this puts the requirement for benchmarks on the lint workflow. Should this be the lint or build step. Theres arguments for both.

@shahzadlone
Copy link
Member Author

From what I can tell, this puts the requirement for benchmarks on the lint workflow. Should this be the lint or build step. Theres arguments for both.

I wanted to ensure that all workflows are successful before benchmarks are ran, however I think it only sets and OR option (trigger if either one of the workflows is successful) rather than if both of those workflows are successful. Currently the benchmark flow never gets triggered due to not being on the default branch. I didn't specifically do the build step to avoid duplication as we already have the build step on CircleCi (should I move that over to Github?).

@jsimnz
Copy link
Member

jsimnz commented Feb 11, 2022

I wanted to ensure that all workflows are successful before benchmarks are ran, however I think it only sets and OR option (trigger if either one of the workflows is successful) rather than if both of those workflows are successful. Currently the benchmark flow never gets triggered due to not being on the default branch. I didn't specifically do the build step to avoid duplication as we already have the build step on CircleCi (should I move that over to Github?).

I know the build/test is on the circle ci, but isn't there still a corresponding github action, or does the CircleCI integration just magically wire things up.

EIther way benchmarks are prob fine to run on lint too.

@jsimnz
Copy link
Member

jsimnz commented Feb 11, 2022

Nvm, I see how things are connecting together, yes depending on the lint workflow is correct!

jsimnz
jsimnz approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone merged commit 536d7db into develop Feb 14, 2022
@shahzadlone shahzadlone deleted the lone/tools/run-bench-on-ec2 branch February 14, 2022 11:50
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Add rule to only run benchmark if other check are successful (sou…
248bbda 
…rcenetwork#194)

MESSAGE:
Add a check to only run the benchmark ec2 runner workflow if the other GitHub workflows are successful.

COMMITS:
* Add a check to only run the benchmark ec2 runner workflow if the other
github workflows are successfull.

* Ready to test, but github actions for workflow runs dependent on each
other only work on default branches apparently.

* Run the benchmarks on the EC2 container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimnz jsimnz jsimnz approved these changes

Assignees

@shahzadlone shahzadlone

Labels
area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. perf Performance issue or suggestion
Projects
None yet
Milestone
DefraDB v0.2.1
Development

Successfully merging this pull request may close these issues.

Integrate new benchmark suite to the CI system
2 participants
@shahzadlone @jsimnz