-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CLI commands for secondary indexes #1595
Conversation
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1595 +/- ##
===========================================
+ Coverage 73.64% 73.67% +0.03%
===========================================
Files 188 193 +5
Lines 19608 19953 +345
===========================================
+ Hits 14439 14699 +260
- Misses 4104 4160 +56
- Partials 1065 1094 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
aa68928
to
c620989
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work Islam! I do have a few things that I'd like to see changed and discussed as you'll see bellow.
c97a417
to
d781503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements Islam. I have a few more things before I approve and then we should be good to go. I'm sorry if some of the comments are repetitive. I used some copy pasting to save me time :)
fe23768
to
12cc0a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks about formatting, :P might be considered personal pref though. One minor todo.
Approving as all else LGTM =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note that I do agree with Shahzad that changing the formatting of the command flags would help readability.
## Relevant issue(s) Resolves sourcenetwork#1553 ## Description Adds following CLI commands: - `client index create` that creates a new index on an existing collection - `client index drop` that drop a named indexes on a collection - `client index list` that lists all existing indexes in db or indexes for a specific collection
Relevant issue(s)
Resolves #1553
Description
Adds following CLI commands:
client index create
that creates a new index on an existing collectionclient index drop
that drop a named indexes on a collectionclient index list
that lists all existing indexes in db or indexes for a specific collectionTasks
How has this been tested?
Unit test, integration tests, manual tests
Specify the platform(s) on which this was tested: