-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CLI client request from file #1503
Merged
orpheuslummis
merged 3 commits into
sourcenetwork:develop
from
orpheuslummis:orpheus/feat/query-from-file
May 15, 2023
Merged
feat: CLI client request from file #1503
orpheuslummis
merged 3 commits into
sourcenetwork:develop
from
orpheuslummis:orpheus/feat/query-from-file
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpheuslummis
added
action/no-benchmark
Skips the action that runs the benchmark.
area/cli
Related to the CLI binary
labels
May 15, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1503 +/- ##
===========================================
- Coverage 72.16% 72.03% -0.14%
===========================================
Files 185 185
Lines 18239 18271 +32
===========================================
- Hits 13162 13161 -1
- Misses 4037 4063 +26
- Partials 1040 1047 +7
|
fredcarle
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
this v0.5.1 or v0.6 ? |
I vote to merge it now :) |
AndrewSisley
approved these changes
May 15, 2023
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1258 ## Description Adds support to read from a file to the `client query` CLI command, via `-f` flag, and a simple test for it, and two related examples in the `/examples` directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1258
Description
Adds support to read from a file to the
client query
CLI command, via-f
flag, and a simple test for it, and two related examples in the/examples
directory.