test: Convert explain dagscan tests to new explain setup #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and change the fixtures to only contain the `typeIndexJoin` part so we can use it across different patterns easily, without making new fixtures all the time.
shahzadlone
added
area/testing
shahzadlone
force-pushed
the
test/refactor-dagscan-explain
branch
2 times, most recently
from
fa3b409 to
d45372f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1474 +/- ##
===========================================
+ Coverage 72.11% 72.23% +0.12%
===========================================
Files 185 185
Lines 18226 18226
===========================================
+ Hits 13143 13166 +23
+ Misses 4040 4023 -17
+ Partials 1043 1037 -6 |
AndrewSisley
approved these changes
May 10, 2023
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…rk#1474) ## Relevant issue(s) - Part of sourcenetwork#953 - Resolves sourcenetwork#1473 ## Description Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot more detail on the entire plan. - Fixes test names and some fixtures for the limit test. - This PR converts all the default dagscan explain tests to the new explain setup. - Converts a wrong usage explain test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Description
Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. #953 Has a lot more detail on the entire plan.