feat: Add commits fieldName and fieldId fields #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
Codecov Report
@@ Coverage Diff @@
## develop #1451 +/- ##
===========================================
- Coverage 72.19% 72.08% -0.11%
===========================================
Files 185 185
Lines 18166 18224 +58
===========================================
+ Hits 13115 13137 +22
- Misses 4017 4044 +27
- Partials 1034 1043 +9
|
AndrewSisley
commented
May 4, 2023
AndrewSisley
force-pushed
the
852-commit-field-name
branch
2 times, most recently
from
89de210 to
13ff861
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
It should never be missing, and is required for fieldId
Callers to this function do not, and really cannot be expected to close the returned planNode if an error is also returned. This means that any errors yielded during the Init call will result in more errors later, for example on txn Discard, which fails with an iterator still open error - masking the original, underlying errror and making debugging much harder than it would otherwise be. I also think it is misleading to have a public `MakePlan` function and have it call an also-public `Init` function and then have the consumer call a public `Start` function - they should either have to call all 3 themselves, or `Init` and `Start` should be private.
Test says it tests fetching the middle cid but only updates once and tests the last cid
Tests will fail in this commit due to cid changes, they will be fixed later alongside once other cid changes have been made.
Breaks the tests as cids have changed. Tests cids will be updated in a later commit alongside other test cids changes required by other commits.
AndrewSisley
force-pushed
the
852-commit-field-name
branch
from
a48d857 to
c8ab219
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#851 sourcenetwork#852 ## Description Adds commits fieldName and fieldId fields, and allows grouping by them. Also fixes a bug in planner where errors in Init would result in unhelpful iterator not closed errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #851 #852
Description
Adds commits fieldName and fieldId fields, and allows grouping by them. Also fixes a bug in planner where errors in Init would result in unhelpful iterator not closed errors.