Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correcting typos #143

Merged
merged 4 commits into from
Mar 1, 2022
Merged

docs: Correcting typos #143

merged 4 commits into from
Mar 1, 2022

Conversation

orpheuslummis
Copy link
Contributor

Correcting a handful of code or string typos.

@codecov
Copy link

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #143 (ab13a2b) into develop (a98e826) will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #143   +/-   ##
========================================
  Coverage    58.57%   58.57%           
========================================
  Files          103      103           
  Lines         9846     9846           
========================================
  Hits          5767     5767           
  Misses        3449     3449           
  Partials       630      630
Impacted Files Coverage Δ
api/http/api.go 0.00% <0.00%> (ø)
core/crdt/composite.go 76.05% <ø> (ø)
db/base/descriptions.go 88.88% <ø> (ø)
db/fetcher/fetcher.go 62.44% <0.00%> (ø)
document/document.go 64.52% <ø> (ø)
document/encoded.go 67.90% <ø> (ø)
document/simple_document.go 0.00% <ø> (ø)
merkle/clock/clock.go 66.98% <ø> (ø)
query/graphql/planner/sort.go 84.28% <ø> (ø)
query/graphql/planner/type_join.go 67.82% <0.00%> (ø)
... and 12 more

@orpheuslummis
Copy link
Contributor Author

orpheuslummis commented Jan 25, 2022 •
edited
Loading

Unsure if better to label as fix or docs for this.

@jsimnz jsimnz added documentation Improvements or additions to documentation refactor This issue specific to or requires *notable* refactoring of existing codebases and components labels Jan 25, 2022
@orpheuslummis orpheuslummis linked an issue Jan 26, 2022 that may be closed by this pull request
Correcting code or string typos #144
Closed
jsimnz
jsimnz reviewed Jan 26, 2022
View reviewed changes
db/base/descriptions.go Outdated Show resolved Hide resolved
jsimnz
jsimnz previously requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single note about FieldKind_Decimal

@orpheuslummis orpheuslummis force-pushed the orpheus/fix-code-typos branch from c8e5b68 to 823bb47 Compare January 26, 2022 02:23
@orpheuslummis orpheuslummis requested a review from jsimnz January 26, 2022 02:24
@shahzadlone
Copy link
Member

Suggestion: can this PR wait until v0.2 release is out? I have had some conflicts recently, it would be nice to minimize conflicts and keep us moving fast until v0.2 is out.

@orpheuslummis orpheuslummis removed the refactor This issue specific to or requires *notable* refactoring of existing codebases and components label Jan 30, 2022
@orpheuslummis orpheuslummis marked this pull request as draft February 2, 2022 20:54
@orpheuslummis orpheuslummis marked this pull request as ready for review February 11, 2022 15:17
@orpheuslummis orpheuslummis changed the title fix: Correcting code or string typos docs: Correcting code or string typos Feb 11, 2022
@orpheuslummis orpheuslummis dismissed jsimnz’s stale review February 11, 2022 15:20

It has been handled

@jsimnz
Copy link
Member

jsimnz commented Feb 11, 2022

Do you still want to get this merged orpheus?

@orpheuslummis
Copy link
Contributor Author

Yes

@orpheuslummis
Copy link
Contributor Author

It can wait until right before the version 0.2.1 is released if that is simpler

@orpheuslummis orpheuslummis marked this pull request as draft March 1, 2022 01:51
@orpheuslummis orpheuslummis force-pushed the orpheus/fix-code-typos branch from d08516a to c82cb7d Compare March 1, 2022 14:56
@orpheuslummis orpheuslummis force-pushed the orpheus/fix-code-typos branch from c82cb7d to 480a4cc Compare March 1, 2022 15:01
@orpheuslummis orpheuslummis marked this pull request as ready for review March 1, 2022 15:03
@orpheuslummis orpheuslummis changed the title docs: Correcting code or string typos docs: Correcting typos Mar 1, 2022
AndrewSisley
AndrewSisley approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

store/wrappedStore.go Show resolved Hide resolved
@orpheuslummis orpheuslummis merged commit 42a3b8b into develop Mar 1, 2022
@orpheuslummis orpheuslummis deleted the orpheus/fix-code-typos branch March 1, 2022 16:58
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
docs: Correcting typos (sourcenetwork#143)
8fa1499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@jsimnz jsimnz Awaiting requested review from jsimnz

@shahzadlone shahzadlone Awaiting requested review from shahzadlone

Assignees

@orpheuslummis orpheuslummis

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correcting code or string typos
4 participants
@orpheuslummis @shahzadlone @jsimnz @AndrewSisley