chore: Enshrine defra logger names

[orpheuslummis]

Relevant issue(s)

Resolves #1148

Description

Simple approach: just rename the loggers.
Suggestion: non-defra loggers could have a prefix like e.g. x.

Tasks

• I made sure the code is well commented, particularly hard-to-understand areas.
• I made sure the repository-held documentation is changed accordingly.
• I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
• I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI

[codecov]

Codecov Report

Merging #1410 (78c2792) into develop (8f72069) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1410      +/-   ##
===========================================
- Coverage    72.19%   72.18%   -0.02%     
===========================================
  Files          185      185              
  Lines        18239    18239              
===========================================
- Hits         13168    13165       -3     
- Misses        4031     4033       +2     
- Partials      1040     1041       +1     

Impacted Files	Coverage Δ
cli/cli.go	70.52% <ø> (ø)
config/config.go	73.30% <ø> (ø)
db/db.go	71.42% <ø> (ø)
logging/logging.go	100.00% <ø> (ø)
merkle/clock/clock.go	65.74% <ø> (ø)
merkle/crdt/merklecrdt.go	47.05% <ø> (ø)
net/api/service.go	12.50% <ø> (ø)
node/node.go	62.59% <ø> (ø)
planner/planner.go	77.37% <ø> (ø)

... and 1 file with indirect coverage changes

[orpheuslummis]

Note that there is another approach to this which is to keep the defra.X nomenclature and just allow logger configuration from both formats defra.X and just X.

[AndrewSisley]

I'm approving the code changes, but am unsure as to whether this is a good feature change long-term.

I can see the defra prefix as being quite handy when embedding defra. I do think explicilty hardcoding the namespaces for every logger instance is quite bad anyway though, and we should probably switch the constructor to some kind of parent-child like mechanic where the namespace is constructed without redefining the strings on every instance - is a problem for another day though, and the code changes here facilitate that somewhat.

[shahzadlone]

Agree with Andy that the prefix is really useful in future when defradb is embedded or used by another tool, to differentiate between defradb logs and other logs for example.

Would make a ticket for automagically handling that through the logger constructor if it won't be done in this PR.

[orpheuslummis]

I don't plan to work on that additional idea. In my view, distinguishing between Defra logs and non-Defra logs is done at a higher level or "the process level", i.e not internal to Defra.

[orpheuslummis]

That said, it is a good idea to figure out how Defra logging can play nice in the embedding case