bot: Bump github.com/ipfs/go-cid from 0.3.2 to 0.4.0 #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/ipfs/go-cid-0.4.0
branch
3 times, most recently
from
a07fdcd to
e7e75f7
Compare
Bumps [github.com/ipfs/go-cid](https://github.com/ipfs/go-cid) from 0.3.2 to 0.4.0. - [Release notes](https://github.com/ipfs/go-cid/releases) - [Commits](ipfs/go-cid@v0.3.2...v0.4.0) --- updated-dependencies: - dependency-name: github.com/ipfs/go-cid dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/ipfs/go-cid-0.4.0
branch
from
e7e75f7 to
9cdde02
Compare
| @@ -35,7 +35,7 @@ func TestQuerySimpleWithInvalidCidAndInvalidDocKey(t *testing.T) { | |||
| }`, | |||
| }, | |||
| }, | |||
| ExpectedError: "invalid CID", | |||
| ExpectedError: "failed to propagate VersionFetcher span: invalid cid: selected encoding not supported", | |||
There was a problem hiding this comment.
I'm unsure about whether we should change the expected error message or have the request error differently.
There was a problem hiding this comment.
The first part of that error feels unnecessary to return to the user. Do you mind checking if you can easily remove it from the returned error?
There was a problem hiding this comment.
I simplified it, IMO it was too specific before. That said, the CID could be validated before that specific step. That would be for a different PR.
Codecov Report
@@ Coverage Diff @@
## develop #1200 +/- ##
===========================================
- Coverage 68.56% 68.54% -0.02%
===========================================
Files 181 181
Lines 17126 17123 -3
===========================================
- Hits 11742 11737 -5
- Misses 4425 4426 +1
- Partials 959 960 +1
|
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results... |
|||||||||||||||
| @@ -224,10 +223,7 @@ func (n *selectNode) initSource() ([]aggregateNode, error) { | |||
| if n.parsed.Cid.HasValue() { | |||
| c, err := cid.Decode(n.parsed.Cid.Value()) | |||
| if err != nil { | |||
| return nil, errors.Wrap( | |||
There was a problem hiding this comment.
praise: Thanks for removing this :)
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results... |
|||||||||||||||
1 similar comment
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results... |
|||||||||||||||
orpheuslummis
deleted the
dependabot/go_modules/github.com/ipfs/go-cid-0.4.0
branch
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
Bumps [github.com/ipfs/go-cid](https://github.com/ipfs/go-cid) from 0.3.2 to 0.4.0. - [Release notes](https://github.com/ipfs/go-cid/releases) - [Commits](ipfs/go-cid@v0.3.2...v0.4.0) --- updated-dependencies: - dependency-name: github.com/ipfs/go-cid dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix: handle the changes in errors * simplify error message * oops 1 line was missing in previous commit --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Orpheus Lummis <[email protected]>
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
) Bumps [github.com/ipfs/go-cid](https://github.com/ipfs/go-cid) from 0.3.2 to 0.4.0. - [Release notes](https://github.com/ipfs/go-cid/releases) - [Commits](ipfs/go-cid@v0.3.2...v0.4.0) --- updated-dependencies: - dependency-name: github.com/ipfs/go-cid dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix: handle the changes in errors * simplify error message * oops 1 line was missing in previous commit --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Orpheus Lummis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/ipfs/go-cid from 0.3.2 to 0.4.0.
Release notes
Sourced from github.com/ipfs/go-cid's releases.
Commits
8098d66chore: version 0.4.0b98e249feat: wrap parsing errors into ErrInvalidCid85c4236build(deps): bump golang.org/x/crypto197da0bbuild(deps): bump golang.org/x/sys06fe289fix: use crypto/rand.Reada1630a3update .github/workflows/release-check.yml225f5dbupdate .github/workflows/go-check.ymlc2c040dupdate .github/workflows/go-test.ymlb729e38bump go.mod to Go 1.19 and run go fix823c6b8Fix README.md example error (#146)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)