Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot breaks validation of PR title #1147

Closed
orpheuslummis opened this issue Feb 24, 2023 · 5 comments · Fixed by #1165
Closed

Dependabot breaks validation of PR title #1147

orpheuslummis opened this issue Feb 24, 2023 · 5 comments · Fixed by #1165
Labels
bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it.
Milestone
DefraDB v0.5

Comments

@orpheuslummis
Copy link
Contributor

The length of the title is too long (should be 60 or less).

addendum:
I'd also personally like to be able to end PR titles with `
@orpheuslummis orpheuslummis added bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it. labels Feb 24, 2023
@orpheuslummis orpheuslummis added this to the DefraDB v0.5 milestone Feb 24, 2023
@AndrewSisley
Copy link
Contributor

AndrewSisley commented Feb 24, 2023 •
edited
Loading

I'd also personally like to be able to end PR titles with `

Why?

@fredcarle
Copy link
Collaborator

I'd also personally like to be able to end PR titles with `

Why?

I would be happy with the too.

feat: Add collection subscription to p2p

Using ` helps to show that it's some kind of object.

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Feb 24, 2023 •
edited
Loading

😅 It is a commit title, not a rich text body. I wont fight you guys though lol

@fredcarle
Copy link
Collaborator

😅 It is a commit title, not a rich text body. I wont fight you guys though lol

It's a commit title but it's also rich text as part of the PR title. 🙂
image

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Feb 24, 2023 •
edited
Loading

😁 Actually I'm wrong. It isn't a commit message, it's just we automatically take the PR title as the default commit message (which can be modified first). Disapproval withdrawn 😆

@orpheuslummis orpheuslummis mentioned this issue Mar 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging a pull request may close this issue.

ci: Changes for dependabot to be well-behaved sourcenetwork/defradb
3 participants
@orpheuslummis @fredcarle @AndrewSisley