-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Github as authentication server #4
Comments
Will you have a look at this @eoaksnes? |
There seems to be an additional issue with GitHub: the request to get the access token is blocked (using the release code)
See https://stackoverflow.com/questions/42150075/cors-issue-on-github-oauth isaacs/github#330 |
I enable this in the backend code, allow_origins=[http://localhost, http://localhost:3000,....] |
So my understanding is that Github requires the "client_secret" in the token request. Which can't be added to the SPA web client. Therefore, you must setup your own backend API with the client_secret, that the web app can send the token request to. Do you have some sample code for endpoint for this backend API @eoaksnes? |
Stale issue message |
The latest commits to this PR; #6 adds support for auth via "Gihub OAuth Apps", which is a bit different than "Github Apps". However they both require you to setup an API to forward the web client requests, with the added "client_secret", to the github API. Let me know if you decide to test this alpha release and happen to find any issues @bonndan. |
Changes that needs to be done:
The text was updated successfully, but these errors were encountered: