Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio automtls mode with security.istio.io/tlsMode=disabled results in sending mTLS #10575

Closed
stevenctl opened this issue Jan 15, 2025 · 0 comments · Fixed by #10574
Closed

Comments

@stevenctl
Copy link

Gloo Edge Product

Open Source

Gloo Edge Version

v1.18.x

Kubernetes Version

v1.30.x

Describe the bug

We're using the condition if _, ok := labels[constants.IstioTlsModeLabel]; ok { to add the mutual tls transport socket match metadata. Instead of the presence of the label, we need to check the value as well.

Expected Behavior

If the label value is disabled we shouldn't add the filter metadata resulting in mTLS being sent.

Steps to reproduce the bug

Install Istio and gloo gateway, with the istio integration enabled.

Label a non-injected backend pod with security.istio.io/tlsMode=disabled and try to send traffic to it; it will fail.

Additional Environment Detail

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant