Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating rubygems in the CI #189

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Fix updating rubygems in the CI #189

merged 3 commits into from
Sep 8, 2022

Conversation

elia
Copy link
Member

@elia elia commented Sep 7, 2022 •
edited
Loading

Summary

The gem update --system command is silently failing in the CI and a bunch of random failures seem to be tied to an older version of Rubygems.

In this case adding sudo is the correct solution on circleci docker images.

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.

@elia elia self-assigned this Sep 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2022

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify bot added the needs changelog label Needs a label to determine the type of change. label Sep 7, 2022
elia added 3 commits September 8, 2022 09:11
@elia
Updating RubyGems requires sudo inside CircleCI images
f372280
@elia
Pin the async gem to a ruby < 3 compatible version
29a3593 
Fixes #181.

While we still support Ruby < 3 we need to workaround a limitation in
the 'async' gem that relies on the latest ruby, since RubyGems doesn't
resolve gems based on the required ruby version.
@elia
Don't define methods on object
a5f15d2
@elia elia force-pushed the elia/rubygems-update branch from 1430af1 to a5f15d2 Compare September 8, 2022 07:13
@elia elia marked this pull request as ready for review September 8, 2022 10:24
@elia elia added infrastructure Internal change — changelog entry not needed. and removed needs changelog label Needs a label to determine the type of change. labels Sep 8, 2022
waiting-for-dev
waiting-for-dev approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@mergify mergify bot merged commit 4ed229b into master Sep 8, 2022
@mergify mergify bot deleted the elia/rubygems-update branch September 8, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees

@elia elia

Labels
infrastructure Internal change — changelog entry not needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @waiting-for-dev