Frontend form #21
Closed
Frontend form #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into frontend-form
Merged
|
Closing in favor of #22 |
gsmendoza
pushed a commit
to gsmendoza/solidus_braintree
that referenced
this pull request
Dec 28, 2022
…ource Save payment type to source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix #14 by using the Braintree Drop-In form on the frontend. The biggest question I have is about the API endpoint. I have removed the
:authenticate_usercall on that endpoint to allow guests to check. Not sure if that is the best way to do that or if there is a better way.I would appreciate any comments or questions about the implementation.