Backport SolidusBraintree README changes to v2.x #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offenses:
app/models/solidus_braintree/transaction.rb:20:21: C: [Correctable] Style/InverseMethods: Use invalid? instead of inverting valid?.
if address && !address.valid?
^^^^^^^^^^^^^^^
app/models/solidus_braintree/transaction_import.rb:12:57: C: [Correctable] Style/InverseMethods: Use invalid? instead of inverting valid?.
errors.add("Address", "is invalid") if address && !address.valid?
^^^^^^^^^^^^^^^
app/models/solidus_braintree/transaction_import.rb:14:10: C: [Correctable] Style/InverseMethods: Use invalid? instead of inverting valid?.
if !transaction.valid?
^^^^^^^^^^^^^^^^^^^
Offenses:
app/models/solidus_braintree/transaction.rb:20:10: C: [Correctable] Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.
if address && address.invalid?
^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/solidus_braintree/transaction_import.rb:12:46: C: [Correctable] Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.
errors.add("Address", "is invalid") if address && address.invalid?
^^^^^^^^^^^^^^^^^^^^^^^^^^^
gsmendoza
force-pushed
the
gsmendoza/131-backport-readme-changes
branch
from
280886a to
999fbc4
Compare
gsmendoza
commented
Mar 16, 2023
| @@ -17,7 +17,7 @@ class Transaction | |||
| unless payment_method.is_a? SolidusBraintree::Gateway | |||
| errors.add(:payment_method, 'Must be braintree') | |||
| end | |||
| if address && !address.valid? | |||
| if address&.invalid? | |||
There was a problem hiding this comment.
Cherry-picked these commits to fix the RuboCop offenses in the CI.
gsmendoza
commented
Mar 16, 2023
| @@ -9,9 +9,9 @@ class InvalidImportError < StandardError; end | |||
| include ActiveModel::Model | |||
|
|
|||
| validate do | |||
| errors.add("Address", "is invalid") if address && !address.valid? | |||
| errors.add("Address", "is invalid") if address&.invalid? | |||
There was a problem hiding this comment.
Cherry-picked these commits to fix the RuboCop offenses in the CI.
kennyadsl
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #131.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: