You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I discussed it with @piyushswain and @michellecrisologo, but I don't think it will be ok, because the perform! method is automatically executed when the Refund is created. If someone installs rubocop-solidus on a previous solidus version it will autocorrect it, calling the method twice.
From Solidus v3.0 onwards, #perform! will need to be explicitly called when creating new refunds. Please, change your code from:
Spree::Refund.create(your: attributes)
to:
Spree::Refund.create(your: attributes, perform_after_creation: false).perform!
The perform_after_creation attribute will be removed in Solidus 3.x.
Stop calling perform! as Spree::Refund after_create callback #3641 (kennyadsl)
Look for:
For solidus 2.11 looks for Spree::Refund.create/new without perform_after_create
For Solidus < 2.11 we can consider patching the model by overriding the method as done here:
solidusio/solidus@3d6f510
solidus_minimum_version: 2.11
The text was updated successfully, but these errors were encountered: