2626#define UBNT_LEDBAR_MAX_BRIGHTNESS 0xff
2727
2828#define UBNT_LEDBAR_TRANSACTION_LENGTH 8
29- #define UBNT_LEDBAR_TRANSACTION_SUCCESS 0xaa
29+ #define UBNT_LEDBAR_TRANSACTION_SUCCESS (char) 0xaa
3030
3131#define UBNT_LEDBAR_TRANSACTION_BLUE_IDX 2
3232#define UBNT_LEDBAR_TRANSACTION_GREEN_IDX 3
3333#define UBNT_LEDBAR_TRANSACTION_RED_IDX 4
34+ #define UBNT_LEDBAR_TRANSACTION_LED_COUNT_IDX 6
3435
3536struct ubnt_ledbar {
3637 struct mutex lock ;
38+ u32 led_count ;
3739 struct i2c_client * client ;
3840 struct led_classdev led_red ;
3941 struct led_classdev led_green ;
4042 struct led_classdev led_blue ;
4143 struct gpio_desc * enable_gpio ;
44+ struct gpio_desc * reset_gpio ;
4245};
4346
44- static int ubnt_ledbar_perform_transaction (struct ubnt_ledbar * ledbar ,
45- char * transaction )
47+ static void ubnt_ledbar_perform_transaction (struct ubnt_ledbar * ledbar ,
48+ const char * transaction , int len ,
49+ char * result , int result_len )
4650{
47- int ret ;
4851 int i ;
4952
50- for (i = 0 ; i < UBNT_LEDBAR_TRANSACTION_LENGTH ; i ++ )
53+ for (i = 0 ; i < len ; i ++ )
5154 i2c_smbus_write_byte (ledbar -> client , transaction [i ]);
5255
53- return i2c_smbus_read_byte (ledbar -> client );
56+ for (i = 0 ; i < result_len ; i ++ )
57+ result [i ] = i2c_smbus_read_byte (ledbar -> client );
5458}
5559
5660static int ubnt_ledbar_apply_state (struct ubnt_ledbar * ledbar )
5761{
5862 char setup_msg [UBNT_LEDBAR_TRANSACTION_LENGTH ] = {0x40 , 0x10 , 0x00 , 0x00 ,
5963 0x00 , 0x00 , 0x00 , 0x11 };
6064 char led_msg [UBNT_LEDBAR_TRANSACTION_LENGTH ] = {0x40 , 0x00 , 0x00 , 0x00 ,
61- 0x00 , 0x00 , 0x01 , 0x00 };
65+ 0x00 , 0x00 , 0x00 , 0x00 };
6266 char i2c_response ;
6367 int ret = 0 ;
6468
@@ -67,34 +71,63 @@ static int ubnt_ledbar_apply_state(struct ubnt_ledbar *ledbar)
6771 led_msg [UBNT_LEDBAR_TRANSACTION_BLUE_IDX ] = ledbar -> led_blue .brightness ;
6872 led_msg [UBNT_LEDBAR_TRANSACTION_GREEN_IDX ] = ledbar -> led_green .brightness ;
6973 led_msg [UBNT_LEDBAR_TRANSACTION_RED_IDX ] = ledbar -> led_red .brightness ;
74+ led_msg [UBNT_LEDBAR_TRANSACTION_LED_COUNT_IDX ] = ledbar -> led_count ;
7075
71- gpiod_set_raw_value (ledbar -> enable_gpio , 1 );
76+ gpiod_set_value (ledbar -> enable_gpio , 1 );
7277
7378 msleep (10 );
7479
75- i2c_response = ubnt_ledbar_perform_transaction (ledbar , setup_msg );
80+ ubnt_ledbar_perform_transaction (ledbar , setup_msg , sizeof ( setup_msg ), & i2c_response , sizeof ( i2c_response ) );
7681 if (i2c_response != UBNT_LEDBAR_TRANSACTION_SUCCESS ) {
77- dev_err (& ledbar -> client -> dev , "Error initializing LED transaction: %02x \n" , ret );
82+ dev_err (& ledbar -> client -> dev , "Error initializing LED transaction: %02hhx \n" , i2c_response );
7883 ret = - EINVAL ;
7984 goto out_gpio ;
8085 }
8186
82- i2c_response = ubnt_ledbar_perform_transaction (ledbar , led_msg );
87+ ubnt_ledbar_perform_transaction (ledbar , led_msg , sizeof ( led_msg ), & i2c_response , sizeof ( i2c_response ) );
8388 if (i2c_response != UBNT_LEDBAR_TRANSACTION_SUCCESS ) {
84- dev_err (& ledbar -> client -> dev , "Failed LED transaction: %02x \n" , ret );
89+ dev_err (& ledbar -> client -> dev , "Failed LED transaction: %02hhx \n" , i2c_response );
8590 ret = - EINVAL ;
8691 goto out_gpio ;
8792 }
8893
8994 msleep (10 );
9095out_gpio :
91- gpiod_set_raw_value (ledbar -> enable_gpio , 0 );
96+ gpiod_set_value (ledbar -> enable_gpio , 0 );
9297
9398 mutex_unlock (& ledbar -> lock );
9499
95100 return ret ;
96101}
97102
103+ static void ubnt_ledbar_reset (struct ubnt_ledbar * ledbar )
104+ {
105+ static const char init_msg [16 ] = {0x02 , 0x81 , 0xfd , 0x7e ,
106+ 0x00 , 0x00 , 0x00 , 0x00 ,
107+ 0x00 , 0x00 , 0x00 , 0x00 ,
108+ 0x00 , 0x00 , 0x00 , 0x00 };
109+ char init_response [4 ];
110+
111+ if (!ledbar -> reset_gpio )
112+ return ;
113+
114+ mutex_lock (& ledbar -> lock );
115+
116+ gpiod_set_value (ledbar -> reset_gpio , 1 );
117+ msleep (10 );
118+ gpiod_set_value (ledbar -> reset_gpio , 0 );
119+
120+ msleep (10 );
121+
122+ gpiod_set_value (ledbar -> enable_gpio , 1 );
123+ msleep (10 );
124+ ubnt_ledbar_perform_transaction (ledbar , init_msg , sizeof (init_msg ), init_response , sizeof (init_response ));
125+ msleep (10 );
126+ gpiod_set_value (ledbar -> enable_gpio , 0 );
127+
128+ mutex_unlock (& ledbar -> lock );
129+ }
130+
98131#define UBNT_LEDBAR_CONTROL_RGBS (name ) \
99132static int ubnt_ledbar_set_##name##_brightness(struct led_classdev *led_cdev,\
100133 enum led_brightness value) \
@@ -153,14 +186,26 @@ static int ubnt_ledbar_probe(struct i2c_client *client,
153186 return ret ;
154187 }
155188
156- gpiod_direction_output (ledbar -> enable_gpio , 0 );
189+ ledbar -> reset_gpio = devm_gpiod_get_optional (& client -> dev , "reset" , GPIOD_OUT_LOW );
190+
191+ if (IS_ERR (ledbar -> reset_gpio )) {
192+ ret = PTR_ERR (ledbar -> reset_gpio );
193+ dev_err (& client -> dev , "Failed to get reset gpio: %d\n" , ret );
194+ return ret ;
195+ }
196+
197+ ledbar -> led_count = 1 ;
198+ of_property_read_u32 (np , "led-count" , & ledbar -> led_count );
157199
158200 ledbar -> client = client ;
159201
160202 mutex_init (& ledbar -> lock );
161203
162204 i2c_set_clientdata (client , ledbar );
163205
206+ // Reset and initialize the MCU
207+ ubnt_ledbar_reset (ledbar );
208+
164209 ledbar -> led_red .brightness_set_blocking = ubnt_ledbar_set_red_brightness ;
165210 ubnt_ledbar_init_led (of_get_child_by_name (np , "red" ), ledbar , & ledbar -> led_red );
166211
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?v=4&size=40){kind=avatar}
0 commit comments