Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No json4s release for scala 3 #2153

Closed
dwischolek-modulon opened this issue Apr 25, 2024 · 4 comments · Fixed by #2154
Closed

No json4s release for scala 3 #2153

dwischolek-modulon opened this issue Apr 25, 2024 · 4 comments · Fixed by #2154

Comments

@dwischolek-modulon
Copy link

There is still no json4s binding release for scala 3. Is there something missing? A corresponding pull request #1095 was closed in 2021.

@adamw
Copy link
Member

adamw commented Apr 25, 2024

The PR was closed, not merged. There where some issues, maybe they are now resolved. Can you try creating another PR?

@dwischolek-modulon
Copy link
Author

Not knowing what those issues were and not being to deep into this project, I would rather not. At least not without some more information. Maybe @nryanov does remember and can shed some light onto it.

@adamw
Copy link
Member

adamw commented Apr 26, 2024

Turns out it just worked

@dwischolek-modulon
Copy link
Author

Nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants