Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend rate limiter to support whole operation execution time, not just the start #246

Closed
adamw opened this issue Nov 25, 2024 · 0 comments · Fixed by #251
Closed

Extend rate limiter to support whole operation execution time, not just the start #246

adamw opened this issue Nov 25, 2024 · 0 comments · Fixed by #251
Assignees

Comments

@adamw
Copy link
Member

adamw commented Nov 25, 2024

Currently, the rate limiter only takes into account the start of execution of an operation - and limits basing on this.

However, in some scenarios we should take into account the whole duration. E.g. if there's an HTTP request which we want to rate limit, the actual HTTP invocation might happen anytime between the start and end of an httpRequest.send(...) call.

The goal of this task is to design an API which would extend what's currently available, and support both start-time & whole-duration rate limits, using all three algorithms (fixed windows, sliding window, leaky bucket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants