Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Compile fails on react native 0.78.0 #2635

Closed
jonluca opened this issue Feb 19, 2025 · 12 comments · Fixed by #2619
Closed

iOS Compile fails on react native 0.78.0 #2635

jonluca opened this issue Feb 19, 2025 · 12 comments · Fixed by #2619

Comments

@jonluca
Copy link

jonluca commented Feb 19, 2025

Description

The module fails to compile - Compiling react-native-svg Pods/RNSVG » RNSVGGroup.mm

The following build commands failed:
	CompileC /Users/expo/Library/Developer/Xcode/DerivedData/Weights-dqqzqcrfobomtkdpsjeqmpbzsjar/Build/Intermediates.noindex/ArchiveIntermediates/Weights/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/RNSVG.build/Objects-normal/arm64/RNSVGLayoutableShadowNode.o /Users/expo/workingdir/build/node_modules/react-native-svg/common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'RNSVG' from project 'Pods')
Error: The "Run fastlane" step failed because of an error in the Xcode build process. We automatically detected following errors in your Xcode build logs:
- no viable conversion from 'StyleLength' to 'Style::SizeLength' (aka 'facebook::yoga::StyleSizeLength')
- no viable conversion from 'StyleLength' to 'Style::SizeLength' (aka 'facebook::yoga::StyleSizeLength')
Refer to "Xcode Logs" below for additional, more detailed logs.

Steps to reproduce

Attempt to build an IOS project on RN 0.78.0 with the new architecture and the latest version of react-native-svg

Snack or a link to a repository

https://snack.expo.dev/@jonluca/svg-fail

SVG version

15.11.1

React Native version

0.78.0

Platforms

iOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

@erie-e9
Copy link

erie-e9 commented Feb 19, 2025

+1

@jakex7 jakex7 linked a pull request Feb 19, 2025 that will close this issue
@jakex7 jakex7 reopened this Feb 19, 2025
@jakex7
Copy link
Member

jakex7 commented Feb 19, 2025

Hey! Thanks for reporting this issue. I've merged support for [email protected] in #2619 and will release it as soon as possible.

@hungcuongDev
Copy link

Are there any new updates on the issue yet? I'm still getting this error when updating to RN 0.78.0

@okaybeydanol
Copy link

I'm also getting the same error RN 0.78.0. I'm waiting for your new release to continue my project. I hope you can release it as soon as possible.

@anhtuanMDev
Copy link

Same problem but with android, hope the new version came out soon

@okaybeydanol
Copy link

When I got an error on iOS, I didn’t even try Android 😅

@Skaff02
Copy link

Skaff02 commented Feb 22, 2025

Same problem, I hope it doesn't take too much time to get fixed

@mtnt
Copy link

mtnt commented Feb 22, 2025

you can change

#if REACT_NATIVE_MINOR_VERSION >= 77
  style.setDimension(yoga::Dimension::Width, yoga::StyleLength::points(0));
  style.setDimension(yoga::Dimension::Height, yoga::StyleLength::points(0));

to

#if REACT_NATIVE_MINOR_VERSION >= 77
  style.setDimension(yoga::Dimension::Width, yoga::Style::SizeLength::points(0));
  style.setDimension(yoga::Dimension::Height, yoga::Style::SizeLength::points(0));

I have no idea if it is correct, but it helps to build an app =) just a workaround

@irmakcosarsahna
Copy link

Thanks, it's a temporary fix, but we need a permanent update.

you can change

#if REACT_NATIVE_MINOR_VERSION >= 77
  style.setDimension(yoga::Dimension::Width, yoga::StyleLength::points(0));
  style.setDimension(yoga::Dimension::Height, yoga::StyleLength::points(0));

to

#if REACT_NATIVE_MINOR_VERSION >= 77
  style.setDimension(yoga::Dimension::Width, yoga::Style::SizeLength::points(0));
  style.setDimension(yoga::Dimension::Height, yoga::Style::SizeLength::points(0));

I have no idea if it is correct, but it helps to build an app =) just a workaround

@1280103995
Copy link

Image

@hari-mohan-choudhary
Copy link

I am also getting this issue on android on react-native 0.78.0

Image

@jakex7
Copy link
Member

jakex7 commented Feb 24, 2025

Hey everyone! Version 15.11.2 supporting [email protected], has been released. Thanks for your patience! If you have any issues with the upgrade, feel free to ping me here or open a new issue.

@jakex7 jakex7 closed this as completed Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.