Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please replace org.jetbrains.annotations with androidx.annotation #1854

Closed
dpott197 opened this issue Sep 3, 2022 · 3 comments
Closed

Please replace org.jetbrains.annotations with androidx.annotation #1854

dpott197 opened this issue Sep 3, 2022 · 3 comments

Comments

@dpott197
Copy link

dpott197 commented Sep 3, 2022

Bug

Attempted to upgrade from 12.4.4 to 13.1.0. When I compile my project, I get the error below.

world50/platform/packages/member-app/node_modules/react-native-svg/android/src/paper/java/com/horcrux/svg/FabricEnabledViewGroup.java:5: error: package org.jetbrains.annotations does not exist
import org.jetbrains.annotations.Nullable;

Could you please update https://github.com/react-native-svg/react-native-svg/blob/67755288c0a5d9ab19aacbf949a4c2776e52d803/android/src/fabric/java/com/horcrux/svg/FabricEnabledViewGroup.java#L15 with the following?

Remove

import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

Add

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

Unexpected behavior

Environment info

React native info output:

yarn run v1.19.1
$ react-native info
info Fetching system and libraries information...
System:
    OS: macOS 12.5.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 27.49 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.13.2 - /var/folders/87/nnscf2zn14940l8jnmpcq06c0000gq/T/yarn--1662203422008-0.7199911194344797/node
    Yarn: 1.19.1 - /var/folders/87/nnscf2zn14940l8jnmpcq06c0000gq/T/yarn--1662203422008-0.7199911194344797/yarn
    npm: 8.3.1 - ~/.nvm/versions/node/v16.13.2/bin/npm
    Watchman: 2022.08.22.00 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /Users/darren.pottinger/.rvm/gems/ruby-3.0.0/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 21, 29, 30, 31, 32
      Build Tools: 29.0.2, 30.0.2, 30.0.3, 32.0.0, 33.0.0
      System Images: android-21 | Google APIs Intel x86 Atom, android-21 | Google APIs Intel x86 Atom_64, android-23 | Intel x86 Atom, android-23 | Google APIs Intel x86 Atom, android-24 | Google Play Intel x86 Atom, android-25 | Google Play Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom_64, android-30 | Intel x86 Atom_64, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom, android-31 | Google APIs Intel x86 Atom_64, android-31 | Google Play Intel x86 Atom_64
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8609683
    Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.12 - /usr/bin/javac
    Python: Not Found
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: ~0.63.4 => 0.63.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found
✨  Done in 7.87s.

Library version: 13.1.0

@WoLewicki
Copy link
Member

Since #1851 has been merged and I believe we do not need FabricEnabledViewGroup at all I will close this issue.

@darigoce
Copy link

darigoce commented Sep 7, 2022

I think the package.json needs to be updated, because even after a fresh npm intall I am still getting the FabricEnabledViewGroup file

@warrence
Copy link

I'm also still getting FabricEnabledViewGroup, any solution on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants