Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: software-mansion/react-native-screens
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.28.0
Choose a base ref
...
head repository: software-mansion/react-native-screens
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.29.0
Choose a head ref
  • 2 commits
  • 18 files changed
  • 2 contributors

Commits on Dec 7, 2023

  1. fix(iOS): select correct VC for nested modal presentation (#1912) 

    ## Description

Closes #1829

Currently it is not possible to navigate to a modal from another modal
view that is mounted in JS under nested stack (see #1829 description for
better context).
This is the case, because modal is presented by
`RNSNavigationController` corresponding to the stack under which it is
mounted in JS ==> UIKit reports that such controller is already
presenting.

IMO the last presented modal should be the one, to present new one.


## Changes

Added code handling above case, by checking whether modals from other
stacks are present & using top-most modal for presentation in such case.

## Test code and steps to reproduce

See `Test1829` in test example apps

## Checklist

- [x] Included code example that can be used to test this change
- [x] Ensured that CI passes (merged only comments after final CI
checks)
    @kkafar
    kkafar authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    471127e View commit details
    Browse the repository at this point in the history

  2. Release 3.29.0

    @kkafar
    kkafar committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0164979 View commit details
    Browse the repository at this point in the history
Loading