Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reanimated 2.1.0 makes the Hermes Debugger in Flipper crash #1923

Closed
1 of 3 tasks
andreialecu opened this issue Apr 8, 2021 · 12 comments
Closed
1 of 3 tasks

Reanimated 2.1.0 makes the Hermes Debugger in Flipper crash #1923

andreialecu opened this issue Apr 8, 2021 · 12 comments

Comments

@andreialecu
Copy link
Contributor

Description

Been troubleshooting an issue with the app crashing when using the Hermes Debugger:

facebook/hermes#491

I noticed in the device logs a warning about libjsc.so not being found, but since I was using Hermes that error didn't make much sense. (a similar error report is here: facebook/react-native#25537)

I noticed 2.1.0 added support for JSC. So I reverted to 2.0.1 to see if the warning above was produced by reanimated.

Reverting to 2.0.1 got rid of the libjsc.so warning, and the Hermes Debugger no longer crashes.

Expected behavior

Hermes Debugger should not crash.

Actual behavior & steps to reproduce

Hermes Debugger crashes with RN 0.64 and reanimated 2.1.0 on an Android real device.

A native stack trace can be found in: facebook/hermes#491

Package versions

  • React Native: 0.64
  • React Native Reanimated: 2.1.0

Affected platforms

  • Android
  • iOS
  • Web
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Issue validator

The issue is valid!

@piaskowyk piaskowyk self-assigned this Apr 8, 2021
@andreialecu andreialecu changed the title Reanimates 2.1.0 makes the Hermes Debugger in Flipper crash Reanimated 2.1.0 makes the Hermes Debugger in Flipper crash Apr 11, 2021
@mutablestudio
Copy link

I'm also dealing with this now and can't get a local AS build to run without crashing. I setup a pure RN sample project and added reanimated2 plus hermes 0.7.2, plus some of the standard node_modules. I added rea2 imports to the home screen and rendered an Animated.View. The app will run without any crash (just loading one home screen) on same device that crashes with my own RN app w rea2 (Pixel 3, Anrdoid 11). Sample app is using RN 64.0.

So not sure that this is a rea2 issue, but def seems to be Hermes related. Rolling back now to older Hermes versions to see if that helps.

@andreialecu
Copy link
Contributor Author

I mentioned in the initial post that Reanimated 2.0.1 works. This is related to #1842

@piaskowyk
Copy link
Member

piaskowyk commented Apr 19, 2021

I know the reason and I work on a solution.

@piaskowyk piaskowyk mentioned this issue Apr 23, 2021
1 task
@rplankenhorn
Copy link

@piaskowyk Any update on this?

@oleksandr-dziuban
Copy link

Also waiting this fix, thanks a lot...

@piaskowyk
Copy link
Member

Hey, It will be fixed by: #2047 We want to release a new version tomorrow.

@MaxToyberman
Copy link

Hi !
@piaskowyk flipper works, but changing to debug in developer menu crashes the app.

@jameskennethrobinson
Copy link

@MaxToyberman this is also happening for me. did you find a workaround for opening up the debug menu?

@terrysahaidak
Copy link
Contributor

Hey, @MaxToyberman, could you please open a new issue with all the details? I will help us to track and fix it.

@andreialecu
Copy link
Contributor Author

andreialecu commented Jun 23, 2021

FWIW the debug menu (Chrome debugging) will not work because of React Native's Turbo Modules. It's not Reanimated's fault.

See:
react-native-community/discussions-and-proposals#40 (comment)

Only flipper can be used when Turbo Modules are enabled, which Reanimated 2 uses.

@Echelpoel
Copy link

@andreialecu looks like Chrome debugging support has been added in 2.3.0-alpha.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants