From 394f2c20df5b707bf1109a7ddc3459000a6e8102 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= <40713406+tjzel@users.noreply.github.com> Date: Wed, 27 Nov 2024 17:48:41 +0100 Subject: [PATCH] refactor: rename cpp NativeWorkletsModule to WorkletsModuleProxy (#6767) ## Summary Analogous to: - #6766 `NativeWorkletsModule` is the name of the ObjC/Java modules generated from `WorkletsModule`. It's confusing that we name some Cpp object the same way. With this change Cpp `NativeWorkletsModule` becomes `WorkletsModuleProxy`, the same name we use to refer to it from JavaScript. ## Test plan CI --- .../NativeModules/ReanimatedModuleProxy.cpp | 10 +++++----- .../NativeModules/ReanimatedModuleProxy.h | 12 ++++++------ ...kletsModule.cpp => WorkletsModuleProxy.cpp} | 10 +++++----- ...eWorkletsModule.h => WorkletsModuleProxy.h} | 10 +++++----- ...uleSpec.cpp => WorkletsModuleProxySpec.cpp} | 8 ++++---- ...sModuleSpec.h => WorkletsModuleProxySpec.h} | 4 ++-- .../RNRuntimeWorkletDecorator.cpp | 4 ++-- .../WorkletRuntime/RNRuntimeWorkletDecorator.h | 4 ++-- .../cpp/reanimated/android/NativeProxy.cpp | 18 ++++++++---------- .../main/cpp/reanimated/android/NativeProxy.h | 4 ++-- .../cpp/worklets/android/WorkletsModule.cpp | 4 ++-- .../main/cpp/worklets/android/WorkletsModule.h | 8 ++++---- .../reanimated/apple/native/NativeProxy.mm | 8 ++++---- .../apple/worklets/apple/WorkletsModule.h | 4 ++-- .../apple/worklets/apple/WorkletsModule.mm | 12 ++++++------ 15 files changed, 59 insertions(+), 61 deletions(-) rename packages/react-native-reanimated/Common/cpp/worklets/NativeModules/{NativeWorkletsModule.cpp => WorkletsModuleProxy.cpp} (78%) rename packages/react-native-reanimated/Common/cpp/worklets/NativeModules/{NativeWorkletsModule.h => WorkletsModuleProxy.h} (77%) rename packages/react-native-reanimated/Common/cpp/worklets/NativeModules/{NativeWorkletsModuleSpec.cpp => WorkletsModuleProxySpec.cpp} (71%) rename packages/react-native-reanimated/Common/cpp/worklets/NativeModules/{NativeWorkletsModuleSpec.h => WorkletsModuleProxySpec.h} (82%) diff --git a/packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.cpp b/packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.cpp index 02b4f6a5495..12b4b22fe8b 100644 --- a/packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.cpp +++ b/packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.cpp @@ -52,7 +52,7 @@ using namespace facebook; namespace reanimated { ReanimatedModuleProxy::ReanimatedModuleProxy( - const std::shared_ptr<NativeWorkletsModule> &nativeWorkletsModule, + const std::shared_ptr<WorkletsModuleProxy> &workletsModuleProxy, jsi::Runtime &rnRuntime, const std::shared_ptr<JSScheduler> &jsScheduler, const std::shared_ptr<UIScheduler> &uiScheduler, @@ -63,13 +63,13 @@ ReanimatedModuleProxy::ReanimatedModuleProxy( isBridgeless ? nullptr : jsScheduler->getJSCallInvoker()), isBridgeless_(isBridgeless), isReducedMotion_(isReducedMotion), - nativeWorkletsModule_(nativeWorkletsModule), + workletsModuleProxy_(workletsModuleProxy), jsScheduler_(jsScheduler), uiScheduler_(uiScheduler), - valueUnpackerCode_(nativeWorkletsModule->getValueUnpackerCode()), + valueUnpackerCode_(workletsModuleProxy->getValueUnpackerCode()), uiWorkletRuntime_(std::make_shared<WorkletRuntime>( rnRuntime, - nativeWorkletsModule->getJSQueue(), + workletsModuleProxy->getJSQueue(), jsScheduler_, "Reanimated UI runtime", true /* supportsLocking */, @@ -231,7 +231,7 @@ jsi::Value ReanimatedModuleProxy::createWorkletRuntime( const jsi::Value &initializer) { auto workletRuntime = std::make_shared<WorkletRuntime>( rt, - nativeWorkletsModule_->getJSQueue(), + workletsModuleProxy_->getJSQueue(), jsScheduler_, name.asString(rt).utf8(rt), false /* supportsLocking */, diff --git a/packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.h b/packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.h index 518e5bc7411..f56a5c8c739 100644 --- a/packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.h +++ b/packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.h @@ -12,7 +12,7 @@ #include <reanimated/LayoutAnimations/LayoutAnimationsProxy.h> #endif // RCT_NEW_ARCH_ENABLED -#include <worklets/NativeModules/NativeWorkletsModule.h> +#include <worklets/NativeModules/WorkletsModuleProxy.h> #include <worklets/Registries/EventHandlerRegistry.h> #include <worklets/Tools/JSScheduler.h> #include <worklets/Tools/SingleInstanceChecker.h> @@ -33,7 +33,7 @@ namespace reanimated { class ReanimatedModuleProxy : public ReanimatedModuleProxySpec { public: ReanimatedModuleProxy( - const std::shared_ptr<NativeWorkletsModule> &nativeWorkletsModule, + const std::shared_ptr<WorkletsModuleProxy> &workletsModuleProxy, jsi::Runtime &rnRuntime, const std::shared_ptr<JSScheduler> &jsScheduler, const std::shared_ptr<UIScheduler> &uiScheduler, @@ -174,9 +174,9 @@ class ReanimatedModuleProxy : public ReanimatedModuleProxySpec { return isReducedMotion_; } - [[nodiscard]] inline std::shared_ptr<NativeWorkletsModule> - getNativeWorkletsModule() const { - return nativeWorkletsModule_; + [[nodiscard]] inline std::shared_ptr<WorkletsModuleProxy> + getWorkletsModuleProxy() const { + return workletsModuleProxy_; } private: @@ -193,7 +193,7 @@ class ReanimatedModuleProxy : public ReanimatedModuleProxySpec { const bool isBridgeless_; const bool isReducedMotion_; - const std::shared_ptr<NativeWorkletsModule> nativeWorkletsModule_; + const std::shared_ptr<WorkletsModuleProxy> workletsModuleProxy_; const std::shared_ptr<JSScheduler> jsScheduler_; const std::shared_ptr<UIScheduler> uiScheduler_; const std::string valueUnpackerCode_; diff --git a/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.cpp b/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxy.cpp similarity index 78% rename from packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.cpp rename to packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxy.cpp index 5189d0aa561..c439dc2e6a8 100644 --- a/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.cpp +++ b/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxy.cpp @@ -5,7 +5,7 @@ #include <react/renderer/uimanager/primitives.h> #endif // RCT_NEW_ARCH_ENABLED -#include <worklets/NativeModules/NativeWorkletsModule.h> +#include <worklets/NativeModules/WorkletsModuleProxy.h> #include <worklets/SharedItems/Shareables.h> #ifdef __ANDROID__ @@ -18,16 +18,16 @@ using namespace facebook; namespace worklets { -NativeWorkletsModule::NativeWorkletsModule( +WorkletsModuleProxy::WorkletsModuleProxy( const std::string &valueUnpackerCode, const std::shared_ptr<MessageQueueThread> &jsQueue) - : NativeWorkletsModuleSpec(nullptr), + : WorkletsModuleProxySpec(nullptr), valueUnpackerCode_(valueUnpackerCode), jsQueue_(jsQueue) {} -NativeWorkletsModule::~NativeWorkletsModule() {} +WorkletsModuleProxy::~WorkletsModuleProxy() {} -jsi::Value NativeWorkletsModule::makeShareableClone( +jsi::Value WorkletsModuleProxy::makeShareableClone( jsi::Runtime &rt, const jsi::Value &value, const jsi::Value &shouldRetainRemote, diff --git a/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.h b/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxy.h similarity index 77% rename from packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.h rename to packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxy.h index 13eb581337c..e9fedb04e22 100644 --- a/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.h +++ b/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxy.h @@ -1,7 +1,7 @@ #pragma once #include <cxxreact/MessageQueueThread.h> -#include <worklets/NativeModules/NativeWorkletsModuleSpec.h> +#include <worklets/NativeModules/WorkletsModuleProxySpec.h> #include <worklets/Tools/SingleInstanceChecker.h> #include <worklets/WorkletRuntime/WorkletRuntime.h> #include <memory> @@ -9,13 +9,13 @@ namespace worklets { -class NativeWorkletsModule : public NativeWorkletsModuleSpec { +class WorkletsModuleProxy : public WorkletsModuleProxySpec { public: - explicit NativeWorkletsModule( + explicit WorkletsModuleProxy( const std::string &valueUnpackerCode, const std::shared_ptr<MessageQueueThread> &jsQueue); - ~NativeWorkletsModule(); + ~WorkletsModuleProxy(); jsi::Value makeShareableClone( jsi::Runtime &rt, @@ -35,7 +35,7 @@ class NativeWorkletsModule : public NativeWorkletsModuleSpec { const std::string valueUnpackerCode_; const std::shared_ptr<MessageQueueThread> jsQueue_; #ifndef NDEBUG - SingleInstanceChecker<NativeWorkletsModule> singleInstanceChecker_; + SingleInstanceChecker<WorkletsModuleProxy> singleInstanceChecker_; #endif // NDEBUG }; diff --git a/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.cpp b/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxySpec.cpp similarity index 71% rename from packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.cpp rename to packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxySpec.cpp index 95f05ac8036..624c42ee224 100644 --- a/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.cpp +++ b/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxySpec.cpp @@ -1,9 +1,9 @@ -#include <worklets/NativeModules/NativeWorkletsModuleSpec.h> +#include <worklets/NativeModules/WorkletsModuleProxySpec.h> #include <utility> #define WORKLETS_SPEC_PREFIX(FN_NAME) \ - __hostFunction_NativeWorkletsModuleSpec_##FN_NAME + __hostFunction_WorkletsModuleProxySpec_##FN_NAME namespace worklets { @@ -12,12 +12,12 @@ static jsi::Value WORKLETS_SPEC_PREFIX(makeShareableClone)( TurboModule &turboModule, const jsi::Value *args, size_t) { - return static_cast<NativeWorkletsModuleSpec *>(&turboModule) + return static_cast<WorkletsModuleProxySpec *>(&turboModule) ->makeShareableClone( rt, std::move(args[0]), std::move(args[1]), std::move(args[2])); } -NativeWorkletsModuleSpec::NativeWorkletsModuleSpec( +WorkletsModuleProxySpec::WorkletsModuleProxySpec( const std::shared_ptr<CallInvoker> jsInvoker) : TurboModule("NativeWorklets", jsInvoker) { methodMap_["makeShareableClone"] = diff --git a/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.h b/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxySpec.h similarity index 82% rename from packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.h rename to packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxySpec.h index 1c1d622e17c..c79a86b908f 100644 --- a/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.h +++ b/packages/react-native-reanimated/Common/cpp/worklets/NativeModules/WorkletsModuleProxySpec.h @@ -9,9 +9,9 @@ using namespace react; namespace worklets { -class JSI_EXPORT NativeWorkletsModuleSpec : public TurboModule { +class JSI_EXPORT WorkletsModuleProxySpec : public TurboModule { protected: - explicit NativeWorkletsModuleSpec( + explicit WorkletsModuleProxySpec( const std::shared_ptr<CallInvoker> jsInvoker); public: diff --git a/packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/RNRuntimeWorkletDecorator.cpp b/packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/RNRuntimeWorkletDecorator.cpp index 37565314534..8575570f72b 100644 --- a/packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/RNRuntimeWorkletDecorator.cpp +++ b/packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/RNRuntimeWorkletDecorator.cpp @@ -4,11 +4,11 @@ namespace worklets { void RNRuntimeWorkletDecorator::decorate( jsi::Runtime &rnRuntime, - const std::shared_ptr<NativeWorkletsModule> &nativeWorkletsModule) { + const std::shared_ptr<WorkletsModuleProxy> &workletsModuleProxy) { rnRuntime.global().setProperty( rnRuntime, "__workletsModuleProxy", - jsi::Object::createFromHostObject(rnRuntime, nativeWorkletsModule)); + jsi::Object::createFromHostObject(rnRuntime, workletsModuleProxy)); } } // namespace worklets diff --git a/packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/RNRuntimeWorkletDecorator.h b/packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/RNRuntimeWorkletDecorator.h index 9884e71091a..41cf12b5598 100644 --- a/packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/RNRuntimeWorkletDecorator.h +++ b/packages/react-native-reanimated/Common/cpp/worklets/WorkletRuntime/RNRuntimeWorkletDecorator.h @@ -1,7 +1,7 @@ #pragma once #include <jsi/jsi.h> -#include <worklets/NativeModules/NativeWorkletsModule.h> +#include <worklets/NativeModules/WorkletsModuleProxy.h> #include <memory> using namespace facebook; @@ -13,7 +13,7 @@ class RNRuntimeWorkletDecorator { public: static void decorate( jsi::Runtime &rnRuntime, - const std::shared_ptr<NativeWorkletsModule> &nativeWorkletsModule); + const std::shared_ptr<WorkletsModuleProxy> &workletsModuleProxy); }; } // namespace worklets diff --git a/packages/react-native-reanimated/android/src/main/cpp/reanimated/android/NativeProxy.cpp b/packages/react-native-reanimated/android/src/main/cpp/reanimated/android/NativeProxy.cpp index f88eba94b6e..01e2b1aaefa 100644 --- a/packages/react-native-reanimated/android/src/main/cpp/reanimated/android/NativeProxy.cpp +++ b/packages/react-native-reanimated/android/src/main/cpp/reanimated/android/NativeProxy.cpp @@ -28,7 +28,7 @@ using namespace react; NativeProxy::NativeProxy( jni::alias_ref<NativeProxy::javaobject> jThis, - const std::shared_ptr<NativeWorkletsModule> &nativeWorkletsModule, + const std::shared_ptr<WorkletsModuleProxy> &workletsModuleProxy, jsi::Runtime *rnRuntime, const std::shared_ptr<facebook::react::CallInvoker> &jsCallInvoker, const std::shared_ptr<UIScheduler> &uiScheduler, @@ -42,7 +42,7 @@ NativeProxy::NativeProxy( : javaPart_(jni::make_global(jThis)), rnRuntime_(rnRuntime), reanimatedModuleProxy_(std::make_shared<ReanimatedModuleProxy>( - nativeWorkletsModule, + workletsModuleProxy, *rnRuntime, std::make_shared<JSScheduler>(*rnRuntime, jsCallInvoker), uiScheduler, @@ -58,7 +58,7 @@ NativeProxy::NativeProxy( #ifdef RCT_NEW_ARCH_ENABLED NativeProxy::NativeProxy( jni::alias_ref<NativeProxy::javaobject> jThis, - const std::shared_ptr<NativeWorkletsModule> &nativeWorkletsModule, + const std::shared_ptr<WorkletsModuleProxy> &workletsModuleProxy, jsi::Runtime *rnRuntime, RuntimeExecutor runtimeExecutor, const std::shared_ptr<UIScheduler> &uiScheduler, @@ -68,7 +68,7 @@ NativeProxy::NativeProxy( : javaPart_(jni::make_global(jThis)), rnRuntime_(rnRuntime), reanimatedModuleProxy_(std::make_shared<ReanimatedModuleProxy>( - nativeWorkletsModule, + workletsModuleProxy, *rnRuntime, std::make_shared<JSScheduler>(*rnRuntime, runtimeExecutor), uiScheduler, @@ -123,11 +123,10 @@ jni::local_ref<NativeProxy::jhybriddata> NativeProxy::initHybrid( ) { auto jsCallInvoker = jsCallInvokerHolder->cthis()->getCallInvoker(); auto uiScheduler = androidUiScheduler->cthis()->getUIScheduler(); - auto nativeWorkletsModule = - jWorkletsModule->cthis()->getNativeWorkletsModule(); + auto workletsModuleProxy = jWorkletsModule->cthis()->getWorkletsModuleProxy(); return makeCxxInstance( jThis, - nativeWorkletsModule, + workletsModuleProxy, (jsi::Runtime *)jsContext, jsCallInvoker, uiScheduler, @@ -151,11 +150,10 @@ jni::local_ref<NativeProxy::jhybriddata> NativeProxy::initHybridBridgeless( fabricUIManager) { auto uiScheduler = androidUiScheduler->cthis()->getUIScheduler(); auto runtimeExecutor = runtimeExecutorHolder->cthis()->get(); - auto nativeWorkletsModule = - jWorkletsModule->cthis()->getNativeWorkletsModule(); + auto workletsModuleProxy = jWorkletsModule->cthis()->getWorkletsModuleProxy(); return makeCxxInstance( jThis, - nativeWorkletsModule, + workletsModuleProxy, (jsi::Runtime *)jsContext, runtimeExecutor, uiScheduler, diff --git a/packages/react-native-reanimated/android/src/main/cpp/reanimated/android/NativeProxy.h b/packages/react-native-reanimated/android/src/main/cpp/reanimated/android/NativeProxy.h index 9f312063b8b..175570e10e1 100644 --- a/packages/react-native-reanimated/android/src/main/cpp/reanimated/android/NativeProxy.h +++ b/packages/react-native-reanimated/android/src/main/cpp/reanimated/android/NativeProxy.h @@ -275,7 +275,7 @@ class NativeProxy : public jni::HybridClass<NativeProxy> { explicit NativeProxy( jni::alias_ref<NativeProxy::jhybridobject> jThis, - const std::shared_ptr<NativeWorkletsModule> &nativeWorkletsModule, + const std::shared_ptr<WorkletsModuleProxy> &workletsModuleProxy, jsi::Runtime *rnRuntime, const std::shared_ptr<facebook::react::CallInvoker> &jsCallInvoker, const std::shared_ptr<UIScheduler> &uiScheduler, @@ -290,7 +290,7 @@ class NativeProxy : public jni::HybridClass<NativeProxy> { #ifdef RCT_NEW_ARCH_ENABLED explicit NativeProxy( jni::alias_ref<NativeProxy::jhybridobject> jThis, - const std::shared_ptr<NativeWorkletsModule> &nativeWorkletsModule, + const std::shared_ptr<WorkletsModuleProxy> &workletsModuleProxy, jsi::Runtime *rnRuntime, RuntimeExecutor runtimeExecutor, const std::shared_ptr<UIScheduler> &uiScheduler, diff --git a/packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.cpp b/packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.cpp index 833c5a36cbf..ff2b0401e6f 100644 --- a/packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.cpp +++ b/packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.cpp @@ -24,10 +24,10 @@ WorkletsModule::WorkletsModule( jni::alias_ref<JavaMessageQueueThread::javaobject> messageQueueThread) : javaPart_(jni::make_global(jThis)), rnRuntime_(rnRuntime), - nativeWorkletsModule_(std::make_shared<NativeWorkletsModule>( + workletsModuleProxy_(std::make_shared<WorkletsModuleProxy>( valueUnpackerCode, std::make_shared<JMessageQueueThread>(messageQueueThread))) { - RNRuntimeWorkletDecorator::decorate(*rnRuntime_, nativeWorkletsModule_); + RNRuntimeWorkletDecorator::decorate(*rnRuntime_, workletsModuleProxy_); } jni::local_ref<WorkletsModule::jhybriddata> WorkletsModule::initHybrid( diff --git a/packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.h b/packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.h index e367780de3c..4a771925164 100644 --- a/packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.h +++ b/packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.h @@ -13,7 +13,7 @@ #include <react/jni/JMessageQueueThread.h> #include <react/jni/WritableNativeMap.h> -#include <worklets/NativeModules/NativeWorkletsModule.h> +#include <worklets/NativeModules/WorkletsModuleProxy.h> #include <memory> #include <string> @@ -36,15 +36,15 @@ class WorkletsModule : public jni::HybridClass<WorkletsModule> { static void registerNatives(); - inline std::shared_ptr<NativeWorkletsModule> getNativeWorkletsModule() { - return nativeWorkletsModule_; + inline std::shared_ptr<WorkletsModuleProxy> getWorkletsModuleProxy() { + return workletsModuleProxy_; } private: friend HybridBase; jni::global_ref<WorkletsModule::javaobject> javaPart_; jsi::Runtime *rnRuntime_; - std::shared_ptr<NativeWorkletsModule> nativeWorkletsModule_; + std::shared_ptr<WorkletsModuleProxy> workletsModuleProxy_; explicit WorkletsModule( jni::alias_ref<WorkletsModule::jhybridobject> jThis, diff --git a/packages/react-native-reanimated/apple/reanimated/apple/native/NativeProxy.mm b/packages/react-native-reanimated/apple/reanimated/apple/native/NativeProxy.mm index 1ed3429b2c9..81ad96fd0a0 100644 --- a/packages/react-native-reanimated/apple/reanimated/apple/native/NativeProxy.mm +++ b/packages/react-native-reanimated/apple/reanimated/apple/native/NativeProxy.mm @@ -72,10 +72,10 @@ static inline bool getIsReducedMotion() std::shared_ptr<JSScheduler> jsScheduler = std::make_shared<JSScheduler>(rnRuntime, jsInvoker); constexpr auto isBridgeless = false; - const auto nativeWorkletsModule = [workletsModule getNativeWorkletsModule]; + const auto workletsModuleProxy = [workletsModule getWorkletsModuleProxy]; auto reanimatedModuleProxy = std::make_shared<ReanimatedModuleProxy>( - nativeWorkletsModule, + workletsModuleProxy, rnRuntime, jsScheduler, uiScheduler, @@ -109,13 +109,13 @@ static inline bool getIsReducedMotion() PlatformDepMethodsHolder platformDepMethodsHolder = makePlatformDepMethodsHolderBridgeless(moduleRegistry, nodesManager, reaModule); - const auto nativeWorkletsModule = [workletsModule getNativeWorkletsModule]; + const auto workletsModuleProxy = [workletsModule getWorkletsModuleProxy]; auto uiScheduler = std::make_shared<REAIOSUIScheduler>(); auto jsScheduler = std::make_shared<JSScheduler>(runtime, runtimeExecutor); constexpr auto isBridgeless = true; auto reanimatedModuleProxy = std::make_shared<ReanimatedModuleProxy>( - nativeWorkletsModule, + workletsModuleProxy, runtime, jsScheduler, uiScheduler, diff --git a/packages/react-native-reanimated/apple/worklets/apple/WorkletsModule.h b/packages/react-native-reanimated/apple/worklets/apple/WorkletsModule.h index 25b96da8b9b..5a3b01a10dd 100644 --- a/packages/react-native-reanimated/apple/worklets/apple/WorkletsModule.h +++ b/packages/react-native-reanimated/apple/worklets/apple/WorkletsModule.h @@ -1,9 +1,9 @@ #import <React/RCTBridgeModule.h> #import <React/RCTEventEmitter.h> -#import <worklets/NativeModules/NativeWorkletsModule.h> +#import <worklets/NativeModules/WorkletsModuleProxy.h> @interface WorkletsModule : RCTEventEmitter <RCTBridgeModule> -- (std::shared_ptr<worklets::NativeWorkletsModule>)getNativeWorkletsModule; +- (std::shared_ptr<worklets::WorkletsModuleProxy>)getWorkletsModuleProxy; @end diff --git a/packages/react-native-reanimated/apple/worklets/apple/WorkletsModule.mm b/packages/react-native-reanimated/apple/worklets/apple/WorkletsModule.mm index 77f502ed825..64cb9069439 100644 --- a/packages/react-native-reanimated/apple/worklets/apple/WorkletsModule.mm +++ b/packages/react-native-reanimated/apple/worklets/apple/WorkletsModule.mm @@ -4,8 +4,8 @@ #import <worklets/apple/WorkletsModule.h> #import <worklets/tools/SingleInstanceChecker.h> -using worklets::NativeWorkletsModule; using worklets::RNRuntimeWorkletDecorator; +using worklets::WorkletsModuleProxy; @interface RCTBridge (JSIRuntime) - (void *)runtime; @@ -17,15 +17,15 @@ - (void)_tryAndHandleError:(dispatch_block_t)block; @end @implementation WorkletsModule { - std::shared_ptr<NativeWorkletsModule> nativeWorkletsModule_; + std::shared_ptr<WorkletsModuleProxy> workletsModuleProxy_; #ifndef NDEBUG worklets::SingleInstanceChecker<WorkletsModule> singleInstanceChecker_; #endif // NDEBUG } -- (std::shared_ptr<NativeWorkletsModule>)getNativeWorkletsModule +- (std::shared_ptr<WorkletsModuleProxy>)getWorkletsModuleProxy { - return nativeWorkletsModule_; + return workletsModuleProxy_; } @synthesize moduleRegistry = _moduleRegistry; @@ -39,8 +39,8 @@ @implementation WorkletsModule { auto jsQueue = std::make_shared<WorkletsMessageThread>([NSRunLoop currentRunLoop], ^(NSError *error) { throw error; }); - nativeWorkletsModule_ = std::make_shared<NativeWorkletsModule>(std::string([valueUnpackerCode UTF8String]), jsQueue); - RNRuntimeWorkletDecorator::decorate(rnRuntime, nativeWorkletsModule_); + workletsModuleProxy_ = std::make_shared<WorkletsModuleProxy>(std::string([valueUnpackerCode UTF8String]), jsQueue); + RNRuntimeWorkletDecorator::decorate(rnRuntime, workletsModuleProxy_); return @YES; }