Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file logger #853

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Add file logger #853

merged 2 commits into from
Nov 14, 2024

Conversation

wkozyra95
Copy link
Member

When the compositor is run deep inside some other solution it is sometimes hard to get logs from it. Add file logger should solve that problem

@wkozyra95 wkozyra95 force-pushed the @wkozyra95/support-logging-to-file branch 2 times, most recently from 341afc3 to dac004a Compare November 8, 2024 16:10
@wkozyra95 wkozyra95 marked this pull request as ready for review November 8, 2024 16:11
@WojciechBarczynski
Copy link
Member

WojciechBarczynski commented Nov 14, 2024

Shouldn't this be documented in the changelog and docs?

@wkozyra95 wkozyra95 force-pushed the @wkozyra95/support-logging-to-file branch from dac004a to d495453 Compare November 14, 2024 10:11
@wkozyra95
Copy link
Member Author

Shouldn't this be documented in the changelog and docs?

Changelog yes, for docs I don't plan to update the website, but decided to add it in the markdown file, so when we move to the new site does options are not missed

@wkozyra95 wkozyra95 force-pushed the @wkozyra95/support-logging-to-file branch from d495453 to 9bde0dd Compare November 14, 2024 10:12
@wkozyra95 wkozyra95 force-pushed the @wkozyra95/support-logging-to-file branch from 9bde0dd to 95a91e7 Compare November 14, 2024 10:14
@wkozyra95 wkozyra95 merged commit 01e55fd into master Nov 14, 2024
4 checks passed
@wkozyra95 wkozyra95 deleted the @wkozyra95/support-logging-to-file branch November 14, 2024 11:16
Copy link
Member

@WojciechBarczynski WojciechBarczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants