Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output type that returns data via channel #615

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Add output type that returns data via channel #615

merged 2 commits into from
Jul 10, 2024

Conversation

wkozyra95
Copy link
Member

@wkozyra95 wkozyra95 commented Jul 9, 2024 •
edited
Loading

Add:

  • Output type that returns RGBA wgpu textures via channel
  • Output type that returns h264 and opus encoded chunks
  • Publically expose wgpu::Device and wgpu::Queue (method wgpu_ctx on pipeline)

@wkozyra95 wkozyra95 force-pushed the @wkozyra95/produce-raw-output branch from 0711b0c to fc74800 Compare July 9, 2024 11:27
wkozyra95
wkozyra95 commented Jul 9, 2024
View reviewed changes
src/types/register_output.rs
@@ -71,11 +71,6 @@ pub enum AudioEncoderOptions {

/// (**default="voip"**) Specifies preset for audio output encoder.
preset: Option<OpusEncoderPreset>,

Copy link
Member Author

@wkozyra95 wkozyra95 Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option was ignored

@wkozyra95 wkozyra95 linked an issue Jul 9, 2024 that may be closed by this pull request
Add support for output streams via Rust channel #612
Closed
@wkozyra95 wkozyra95 marked this pull request as ready for review July 9, 2024 13:16
@wkozyra95 wkozyra95 force-pushed the @wkozyra95/produce-raw-output branch from 880cad3 to 0cf91ba Compare July 10, 2024 11:04
@wkozyra95 wkozyra95 merged commit 7568ac3 into master Jul 10, 2024
1 check passed
@wkozyra95 wkozyra95 deleted the @wkozyra95/produce-raw-output branch July 10, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechBarczynski WojciechBarczynski WojciechBarczynski approved these changes

@jerzywilczek jerzywilczek Awaiting requested review from jerzywilczek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for output streams via Rust channel
2 participants
@wkozyra95 @WojciechBarczynski