You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.
Coming from sociomantic-tsunami/dhtnode#25, there might be issues with file descriptors when they are closed in the mutator but the concurrent GC still have them opened.
To avoid this we should either close the FDs in the child (but this requires synchronization between the parent and child, and introduces a bigger pause) or we might just use clone() instead of fork() and actually share the file descriptors with CLONE_FILES (which should even make the forking slightly faster as there are less tables to copy). Since the child will never use those FDs, it should be safe.
The text was updated successfully, but these errors were encountered:
Coming from sociomantic-tsunami/dhtnode#25, there might be issues with file descriptors when they are closed in the mutator but the concurrent GC still have them opened.
To avoid this we should either close the FDs in the child (but this requires synchronization between the parent and child, and introduces a bigger pause) or we might just use
clone()
instead offork()
and actually share the file descriptors withCLONE_FILES
(which should even make the forking slightly faster as there are less tables to copy). Since the child will never use those FDs, it should be safe.The text was updated successfully, but these errors were encountered: