Revisit assert/verify/enforce separation

[mihails-strasuns-sociomantic]

#212 resulted in a very straightforward migration where all assert places got changed to verify/test without any detailed consideration. This unblocks further D2 build deployment but in the long term we would need something finer tuned.

We should revisit all modules either one by one or by package and check what can be changed back to assert and what should really be an enforce with proper exception type. Eventually -release should be able to remove all non-essential checks.

[mathias-lang-sociomantic]

This unblocks further D2 build deployment but in the long term we would need something finer tuned.

Does it ? For the dhtnode, don't we need to do the same in swarm and dhtproto ?

[gavin-norman-sociomantic]

Yes, we need to do the same process in the other libraries. From ocean's side, though, things are complete.

[mihails-strasuns-sociomantic]

Right, I only speak in context of ocean as it is ocean issue :)

[leandro-lucarella-sociomantic]

Maybe a global issue in backend could help track the global progress (or a GitHub project).