Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect_similar() issues deprecation warning #19

Closed
kinto-b opened this issue Jan 21, 2021 · 0 comments
Closed

expect_similar() issues deprecation warning #19

kinto-b opened this issue Jan 21, 2021 · 0 comments
Assignees
Labels
Task: Bug Something isn't working

Comments

@kinto-b
Copy link
Contributor

kinto-b commented Jan 21, 2021

df1 <- data.frame(key = 1:10000, binom_50 = rbinom(10000, 1, 0.5))
df2 <- data.frame(key = 1:10000, binom_51 = rbinom(10000, 1, 0.51))
testdat::expect_similar(binom_50, df2, binom_51, data = df1)
#> Warning: 'glue::collapse' is deprecated.
#> Use 'glue_collapse' instead.
#> See help("Deprecated") and help("glue-deprecated").

Just need to do as the warning message requests and replace glue::collapse with glue::glue_collapse:

Values: {glue::collapse(act$result %>% filter(!pass) %>% pull(!!var), ', ')}

@kinto-b kinto-b added the Task: Bug Something isn't working label Jan 21, 2021
@kinto-b kinto-b self-assigned this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant